fix unit test failures

Signed-off-by: abbyhu2000 <[email protected]>

Author: abbyhu2000

src/core/public/chrome/recently_accessed/recently_accessed_service.ts

@@ -64,15 +64,23 @@ export class RecentlyAccessedService {
         id: string,
         extraProps?: { type?: string; updatedAt?: number }
       ) => {
-        const type = extraProps!.type;
-        const updatedAt = extraProps!.updatedAt;
-        history.add({
-          link,
-          label,
-          id,
-          type,
-          updatedAt,
-        });
+        if (extraProps) {
+          const type = extraProps!.type;
+          const updatedAt = extraProps!.updatedAt;
+          history.add({
+            link,
+            label,
+            id,
+            type,
+            updatedAt,
+          });
+        } else {
+          history.add({
+            link,
+            label,
+            id,
+          });
+        }
       },
 
       /** Gets the current array of history items. */

src/plugins/dashboard/public/application/utils/use/use_saved_dashboard_instance.test.ts

@@ -38,6 +38,7 @@ describe('useSavedDashboardInstance', () => {
         getFilters: () => dashboardAppStateStub.filters,
         optionsJSON: JSON.stringify(dashboardAppStateStub.options),
         getFullPath: () => `/${dashboardIdFromUrl}`,
+        getOpenSearchType: () => 'dashboard',
       },
     } as unknown) as SavedObjectDashboard;
     dashboard = new Dashboard(convertToSerializedDashboard(savedDashboardInstance));

src/plugins/home/public/mocks.ts

@@ -6,8 +6,20 @@
 import { applicationServiceMock, chromeServiceMock, coreMock } from '../../../core/public/mocks';
 import { HomeOpenSearchDashboardsServices } from './application/opensearch_dashboards_services';
 import { injectedMetadataServiceMock } from '../../../core/public/mocks';
+import { featureCatalogueRegistryMock } from './services/feature_catalogue/feature_catalogue_registry.mock';
+import { environmentServiceMock } from './services/environment/environment.mock';
+import { configSchema } from '../config';
+import { tutorialServiceMock } from './services/tutorials/tutorial_service.mock';
+import { sectionTypeServiceMock } from './services/section_type/section_type.mock';
 
-export const createHomeServicesMock = () => {
+const createSetupContract = () => ({
+  featureCatalogue: featureCatalogueRegistryMock.createSetup(),
+  environment: environmentServiceMock.createSetup(),
+  tutorials: tutorialServiceMock.createSetup(),
+  sectionTypes: sectionTypeServiceMock.createSetup(),
+});
+
+export const createStartContract = () => {
   const coreStartMock = coreMock.createStart();
   const chromeMock = chromeServiceMock.createStartContract();
   const applicationMock = applicationServiceMock.createStartContract();
@@ -36,3 +48,8 @@ export const createHomeServicesMock = () => {
     },
   } as unknown) as jest.Mocked<HomeOpenSearchDashboardsServices>;
 };
+
+export const homePluginMock = {
+  createSetupContract,
+  createStartContract,
+};

src/plugins/visualize/public/application/utils/use/use_saved_vis_instance.test.ts

@@ -52,6 +52,8 @@ const mockSavedVisInstance = {
     id: savedVisId,
     title: 'Test Vis',
     destroy: mockSavedVisDestroy,
+    getOpenSearchType: () => 'visualization',
+    getFullPath: () => '/',
   },
   vis: {
     type: {},