Skip to content

TestsShouldNotBePublic should apply to @TestTemplate #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kthoms opened this issue Apr 22, 2025 · 1 comment
Closed

TestsShouldNotBePublic should apply to @TestTemplate #710

kthoms opened this issue Apr 22, 2025 · 1 comment
Assignees
@timtebeek
Labels
enhancement New feature or request

Comments

@kthoms
Copy link
Contributor

kthoms commented Apr 22, 2025

What problem are you trying to solve?

The recipe TestsShouldNotBePublic does not remove the public modifier for tests for methods annotated with org.junit.jupiter.api.TestTemplate.

Describe the solution you'd like

Methods annotated with org.junit.jupiter.api.TestTemplate should be treated as methods annotated with org.junit.jupiter.api.Test

Are you interested in contributing this feature to OpenRewrite?

Sorry, no time ATM.
@kthoms kthoms added the enhancement New feature or request label Apr 22, 2025
@timtebeek
Copy link
Contributor

Thanks for noticing; luckily this was a one line fix a5439b6

@timtebeek timtebeek self-assigned this Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timtebeek timtebeek

Labels
enhancement New feature or request
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kthoms @timtebeek