Added test for manual break of infinite loop

Author: JohannisK

src/main/java/org/openrewrite/staticanalysis/FallThroughVisitor.java

@@ -149,7 +149,7 @@ private static boolean breaks(Statement s) {
                     return !statements.isEmpty() && breaks(statements.get(statements.size() - 1));
                 } else if (s instanceof J.If) {
                     J.If iff = (J.If) s;
-                    return iff.getElsePart() != null && breaks(iff.getThenPart()) && breaks(iff.getThenPart());
+                    return iff.getElsePart() != null && breaks(iff.getThenPart());
                 } else if (s instanceof J.Label) {
                     return breaks(((J.Label) s).getStatement());
                 } else if (s instanceof J.Try) {
@@ -271,7 +271,7 @@ private static boolean returns(Statement s) {
                         if (value.getValue() == Boolean.TRUE) {
                             Statement body = whileLoop.getBody();
                             if (body instanceof J.Block) {
-                                return hasGuaranteedReturn(((J.Block) body).getStatements());
+                                return !hasBreak(((J.Block) body).getStatements()) && hasGuaranteedReturn(((J.Block) body).getStatements());
                             } else {
                                 return hasGuaranteedReturn(Collections.singletonList(whileLoop.getBody()));
                             }
@@ -281,6 +281,15 @@ private static boolean returns(Statement s) {
                 return s instanceof J.Return;
             }
 
+            private static boolean hasBreak(List<Statement> statements) {
+                for(Statement s : statements) {
+                    if(s instanceof J.Break) {
+                        return true;
+                    }
+                }
+                return false;
+            }
+
             @Override
             public J.Case visitCase(J.Case case_, Set<J> ctx) {
                 if (case_ == scope) {

src/test/java/org/openrewrite/staticanalysis/FallThroughTest.java

@@ -531,7 +531,7 @@ void returnNestedInAlwaysTrueLoop() {
           java(
             """
               enum Enum {
-                  A, B, C, D
+                  A, B, C, D, E, F
               }
               public class Test {
                   void foo(Enum a) {
@@ -553,14 +553,28 @@ void foo(Enum a) {
                               while (b) {
                                   return;
                               }
+                          case E:
+                              for (; ; ) {
+                                  if(false) {
+                                      break;
+                                  }
+                                  return;
+                              }
+                          case F:
+                              while (true) {
+                                  if(false) {
+                                      break;
+                                  }
+                                  return;
+                              }
                           default:
                       }
                   }
               }
               """,
             """
               enum Enum {
-                  A, B, C, D
+                  A, B, C, D, E, F
               }
               public class Test {
                   void foo(Enum a) {
@@ -584,6 +598,22 @@ void foo(Enum a) {
                                   return;
                               }
                               break;
+                          case E:
+                              for (; ; ) {
+                                  if(false) {
+                                      break;
+                                  }
+                                  return;
+                              }
+                              break;
+                          case F:
+                              while (true) {
+                                  if(false) {
+                                      break;
+                                  }
+                                  return;
+                              }
+                              break;
                           default:
                       }
                   }