Skip to content

Diff w.r.t Enhanced Memcache #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
petergsnm opened this issue May 16, 2014 · 1 comment
Open

Diff w.r.t Enhanced Memcache #16

petergsnm opened this issue May 16, 2014 · 1 comment

Comments

@petergsnm
Copy link

Hi,

How is this different from the enhanced memcache module of ngx_http_enhanced_memcached_module ?

Can you please clarify why you suggest this not to be integrated with Nginx?

This module is not supposed to be merged into the Nginx core because I've used Ragel to generate the memcached response parsers (in C)

Thanks, Peter

@agentzh
Copy link
Member

agentzh commented May 16, 2014

@petergsnm I've noted several obvious differences:

  1. This ngx_memc module has a much longer history than ngx_enhanced_memcached (more than 2 years older) and is more actively maintained (the last commit to ngx_enhanced_memcached was one year ago while the last commit to ngx_memc was just 1 month ago).
  2. This ngx_memc module takes testing very seriously and comes with a comprehensive test suite that has been frequently run against the latest nginx versions with various testing modes (valgrind, mockeagain, hup reload, leak check, and etc) on Amazon EC2 for years: http://qa.openresty.org I don't see ngx_enhanced_memcached comes with any tests in its git repos.

For better comparison on functionalities and implementations, you'll need to read both modules' documentation and C source, or even do you own testing (I'm not interested in nor have the time to test the ngx_enhanced_memcached module myself).

Can you please clarify why you suggest this not to be integrated with Nginx?
This module is not supposed to be merged into the Nginx core because I've used Ragel to
generate the memcached response parsers (in C)

I take me wrong; I did not suggest that, it is just that the NGINX maintainers dislike machine generated C code (from Ragel, for example). It is that simple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants