Skip to content

Create BoundaryInfo methods for surface or lattice crossing #3295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pshriwise opened this issue Feb 6, 2025 · 2 comments
Open

Create BoundaryInfo methods for surface or lattice crossing #3295

pshriwise opened this issue Feb 6, 2025 · 2 comments
Assignees
@caderache2014
Labels
Other Enhancement

Comments

@pshriwise
Copy link
Contributor

pshriwise commented Feb 6, 2025 •
edited
Loading

Description

Whenever we cross a surface the following boilerplate code appears

if (boundary.lattice_translation[0] != 0 ||
    boundary.lattice_translation[1] != 0 ||
    boundary.lattice_translation[2] != 0) {
  ...
}

A method like bool BoundaryInfo::lattice_crossing() would be useful and more clear.

Alternatives

Leave well enough alone.

Compatibility

Should be an internal refactor, no compatibility issues.
@caderache2014
Copy link
Contributor

@pshriwise if no one objects, I would like to take this on

@pshriwise
Copy link
Contributor Author

It's all yours!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caderache2014 caderache2014

Labels
Other Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@caderache2014 @pshriwise