Skip to content

[feature request] support to configure timezone for kruise-controller-manager #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cvvz opened this issue Mar 5, 2021 · 6 comments
Closed
Assignees
Labels
kind/feature-request wontfix This will not be worked on

Comments

@cvvz
Copy link
Contributor

cvvz commented Mar 5, 2021

What would you like to be added:
support to configure timezone for kruise-controller-manager

Why is this needed:
The timestamp of log in kruise-controller-manager is based on UTC timezone, but timezone in China is UTC+8, which makes it difficult to analyze logs.

@Fei-Guo
Copy link
Member

Fei-Guo commented Mar 19, 2021

Are you sure the timestamp is not consistent with your hardware machine where the container is running?

@stale
Copy link

stale bot commented Jul 13, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jul 13, 2021
@stale stale bot closed this as completed Jul 20, 2021
@qixiaobo
Copy link

https://kubernetes.io/zh/docs/concepts/workloads/controllers/cron-jobs/
So in cronjob spec

Caution:
All CronJob schedule: times are based on the timezone of the kube-controller-manager.

If your control plane runs the kube-controller-manager in Pods or bare containers, the timezone set for the kube->controller-manager container determines the timezone that the cron job controller uses.

The same we should pay attention to kruise-controller

@qixiaobo
Copy link

So maybe helm need provide a parameter like manager.timezone ?

@FillZpp
Copy link
Member

FillZpp commented May 11, 2022

So maybe helm need provide a parameter like manager.timezone ?

#974 will provide a timezone field in acj spec. @qixiaobo

@qixiaobo
Copy link

Thanks for reply. We will have a try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature-request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

5 participants