Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set the ResourceIsPod of DefaultPodValidationOptions to false #1986

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: set the ResourceIsPod of DefaultPodValidationOptions to false #1986

wants to merge 1 commit into from

Conversation

Yesphet
Copy link
Contributor

@Yesphet Yesphet commented Apr 3, 2025

fix #1985

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot requested review from Fei-Guo and furykerry April 3, 2025 03:34
@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fei-guo for approval by writing /assign @fei-guo in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot added the size/XS size/XS: 0-9 label Apr 3, 2025
@ABNER-1
Copy link
Member

ABNER-1 commented Apr 3, 2025

@Yesphet Please fix the DCO check error by following the instructions here: https://github.com/openkruise/kruise/pull/1986/checks?check_run_id=39890896135

Yesphet added a commit to yak2p/kruise that referenced this pull request Apr 3, 2025
@Yesphet
fix: set the ResourceIsPod of DefaultPodValidationOptions to false (o…
5ac3f58 
…penkruise#1986)

Signed-off-by: Yesphet <[email protected]>
@Yesphet Yesphet force-pushed the fix/port_webhook branch from 3aa11fa to 5ac3f58 Compare April 3, 2025 03:37
@Yesphet
Copy link
Contributor Author

Yesphet commented Apr 3, 2025

@Yesphet Please fix the DCO check error by following the instructions here: https://github.com/openkruise/kruise/pull/1986/checks?check_run_id=39890896135

@ABNER-1 fix

@ABNER-1
Copy link
Member

ABNER-1 commented Apr 3, 2025

Perhaps we could add e2e test cases to solidify this scenario for future reference?

@Yesphet
Copy link
Contributor Author

Yesphet commented Apr 3, 2025

@ABNER-1 ok, i will add tests for it

@codecov Codecov
Copy link

codecov bot commented Apr 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.76%. Comparing base (483dc2f) to head (a5224bd).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1986      +/-   ##
==========================================
+ Coverage   42.74%   42.76%   +0.01%     
==========================================
  Files         314      314              
  Lines       31378    31378              
==========================================
+ Hits        13412    13418       +6     
+ Misses      16595    16592       -3     
+ Partials     1371     1368       -3
Flag Coverage Δ
unittests 42.76% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Yesphet Yesphet force-pushed the fix/port_webhook branch from 5ac3f58 to a5224bd Compare April 3, 2025 05:16
@kruise-bot kruise-bot added size/S size/S 10-29 and removed size/XS size/XS: 0-9 labels Apr 3, 2025
@ABNER-1
Copy link
Member

ABNER-1 commented Apr 3, 2025

/lgtm

@kruise-bot kruise-bot added the lgtm label Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fei-Guo Fei-Guo Awaiting requested review from Fei-Guo

@furykerry furykerry Awaiting requested review from furykerry

At least 1 approving review is required to merge this pull request.

Assignees

@ABNER-1 ABNER-1

Labels
lgtm size/S size/S 10-29
Projects
None yet
Milestone
No milestone
3 participants
@Yesphet @kruise-bot @ABNER-1