Skip to content

[PRE REVIEW]: smolyax: a high-performance implementation of the Smolyak interpolation operator in JAX #8204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
editorialbot opened this issue May 15, 2025 · 12 comments
Labels
paused pre-review Track: 7 (CSISM) Computer science, Information Science, and Mathematics

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @JoWestermann (Josephine)
Repository: https://github.com/JoWestermann/smolyax
Branch with paper.md (empty if default branch):
Version: v1.0.0
Editor: Pending
Reviewers: Pending
Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/c8c332e73ab3de1324e5262e887f05ff"><img src="https://joss.theoj.org/papers/c8c332e73ab3de1324e5262e887f05ff/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/c8c332e73ab3de1324e5262e887f05ff/status.svg)](https://joss.theoj.org/papers/c8c332e73ab3de1324e5262e887f05ff)

Author instructions

Thanks for submitting your paper to JOSS @JoWestermann. Currently, there isn't a JOSS editor assigned to your paper.

@JoWestermann if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels May 15, 2025
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.98  T=0.04 s (868.5 files/s, 205425.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                             6            488              0           4237
Python                          15            307            395            934
Jupyter Notebook                 7              0            791            293
Markdown                         2             49              0            246
TeX                              1             12              0            170
TOML                             1              7              0             44
JavaScript                       1              3              3             40
YAML                             1              2              2             19
-------------------------------------------------------------------------------
SUM:                            34            868           1191           5983
-------------------------------------------------------------------------------

Commit count by author:

    30	Josephine Westermann
    26	JoWestermann
    24	joshuawchen
    11	Joshua Chen
     1	huberbenno

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1023/A:1018977404843 is OK
- 10.1017/S0962492904000182 is OK
- 10.1137/S0036144502417715 is OK
- 10.1016/j.jat.2012.11.005 is OK
- 10.1016/j.matpur.2014.04.009 is OK
- 10.1137/1.9781611976885 is OK
- 10.1007/978-3-031-38384-7 is OK
- 10.1007/s10444-024-10171-2 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Quadrature and interpolation formulas for tensor p...
- No DOI given, and none found for title: JAX: composable transformations of Python+NumPy pr...
- No DOI given, and none found for title: Sparse-Grid Approximation of High-Dimensional Para...
- No DOI given, and none found for title: Performance of Neural and Polynomial Operator Surr...

❌ MISSING DOIs

- 10.2307/1266136 may be a valid DOI for title: Handbook of mathematical functions with formulas, ...

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Paper file info:

⚠️ Wordcount for paper.md is 1748

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

LaplaceInterpolation.jl: A Julia package for fast interpolation on a grid
Submitting author: @lootie
Handling editor: @VivianePons (Retired)
Reviewers: @wkearn, @eviatarbach
Similarity score: 0.6925

ndsplines: A Python Library for Tensor-Product B-Splines of Arbitrary Dimension
Submitting author: @sixpearls
Handling editor: @mbobra (Active)
Reviewers: @amritagos, @sarats
Similarity score: 0.6521

JAXbind: Bind any function to JAX
Submitting author: @roth-jakob
Handling editor: @danielskatz (Active)
Reviewers: @dfm, @hawkinsp, @wsmoses
Similarity score: 0.6476

Spiner: Performance Portable Routines for Generic, Tabulated, Multi-Dimensional Data
Submitting author: @Yurlungur
Handling editor: @dfm (Active)
Reviewers: @lgarrison, @jzrake
Similarity score: 0.6461

Re-Envisioning Numerical Information Field Theory (NIFTy.re): A Library for Gaussian Processes and Variational Inference
Submitting author: @Edenhofer
Handling editor: @dfm (Active)
Reviewers: @Abinashbunty, @apizzuto
Similarity score: 0.6373

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@danielskatz
Copy link

👋 @JoWestermann - thanks for your submission.

I see two issues:

  1. Due to the relatively small amount of code, the editors will now discuss if it meets the substantial scholarly effort criterion for review by JOSS. You should hear back in a week or two.
  2. If this does go ahead, you will need to reduce the length of the paper. JOSS's guidelines are 250-1000 words, while your paper is about 1750. In case this doesn't pass our scope review, I don't think you should start reducing the paper yet.

@danielskatz
Copy link

@editorialbot query scope

@editorialbot
Copy link
Collaborator Author

Submission flagged for editorial review.

@editorialbot editorialbot added the query-scope Submissions of uncertain scope for JOSS label May 15, 2025
@JoWestermann
Copy link

Dear @danielskatz, thank you for your this first feedback. In case this might tip the scale in terms of lines of code, we do have several additional features sketched out or in the works that would expand the code base further, and which we could add over the course of a few weeks.
We’re looking forward to hearing back from you and the editors.

@danielskatz
Copy link

@JoWestermann - I'll pause this for now. Let me know when there is more code/features, and also please do reduce the paper length

@danielskatz danielskatz added paused and removed query-scope Submissions of uncertain scope for JOSS labels May 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paused pre-review Track: 7 (CSISM) Computer science, Information Science, and Mathematics
Projects
None yet
Development

No branches or pull requests

3 participants