Skip to content

[PRE REVIEW]: TFDWT: Fast Discrete Wavelet Transform TensorFlow Layers #7968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
editorialbot opened this issue Mar 31, 2025 · 25 comments
Closed
Labels
pre-review query-scope Submissions of uncertain scope for JOSS rejected Track: 7 (CSISM) Computer science, Information Science, and Mathematics

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @kkt-ee (Kishore)
Repository: https://github.com/kkt-ee/TFDWT
Branch with paper.md (empty if default branch):
Version: v0.0.2
Editor: Pending
Reviewers: Pending
Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/6ce3788fe390135e51987bd23959b143"><img src="https://joss.theoj.org/papers/6ce3788fe390135e51987bd23959b143/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/6ce3788fe390135e51987bd23959b143/status.svg)](https://joss.theoj.org/papers/6ce3788fe390135e51987bd23959b143)

Author instructions

Thanks for submitting your paper to JOSS @kkt-ee. Currently, there isn't a JOSS editor assigned to your paper.

@kkt-ee if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Mar 31, 2025
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1038/s41586-020-2649-2 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: TensorFlow
- No DOI given, and none found for title: tensorflow-wavelets: Tensorflow wavelet Layers
- No DOI given, and none found for title: PyTorch
- No DOI given, and none found for title: pytorch-wavelets: A port of the DTCWT toolbox to r...
- No DOI given, and none found for title: Wavelet toolbox

❌ MISSING DOIs

- 10.21105/joss.01237 may be a valid DOI for title: PyWavelets: A Python package for wavelet analysis
- 10.1007/978-3-030-68763-2_46 may be a valid DOI for title: WaveTF: A fast 2D wavelet transform for machine le...
- 10.1109/hotchips.2008.7476520 may be a valid DOI for title: CUDA toolkit and libraries
- 10.1109/icassp49660.2025.10890832 may be a valid DOI for title: Multiresolution Encoder-Decoder Convolutional Neur...

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.98  T=0.05 s (320.5 files/s, 109010.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
XML                              1              0              0           1339
Python                           7            262            392            416
Markdown                         2            154              0            332
Jupyter Notebook                 2              0           1896            178
TeX                              1             10              0             95
TOML                             1              2              0             23
Text                             1              0              0              3
-------------------------------------------------------------------------------
SUM:                            15            428           2288           2386
-------------------------------------------------------------------------------

Commit count by author:

    58	kkt-ee

@editorialbot
Copy link
Collaborator Author

⚠️ An error happened when generating the pdf. Author (Kishore K. Tarafdar) is missing affiliation.

@editorialbot
Copy link
Collaborator Author

Paper file info:

🚨 Wordcount for paper.md is 2958

🔴 Failed to discover a Statement of need section in paper

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

@danielskatz
Copy link

👋 @kkt-ee - thanks for your submission.

However, I see a number of issues.

  1. Your paper does not compile. Please follow the example paper and note that you can click on the error above to find out more about it. In addition, you could work on the possibly missing DOIs that editorialbot suggests, but note that some may be incorrect. Please feel free to make changes to your .bib file, then use the command @editorialbot check references to check again, and the command @editorialbot generate pdf after making changes to the .md file or when the references are right to make a new PDF. editorialbot commands need to be the first entry in a new comment.

  2. Due to the relatively small amount of code, the editors will now discuss if it meets the substantial scholarly effort criterion for review by JOSS. You should hear back in a week or two. If you can make the paper compile (see 1 above), this will help the editors look at the work and determine if we will review it.

  3. Your paper is too long, but don't work on shortening it to the JOSS recommended length of 250-1000 words until we're sure that it will be reviewed.

@kkt-ee
Copy link

kkt-ee commented Apr 1, 2025

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

⚠️ An error happened when generating the pdf. Author (Kishore K. Tarafdar) is missing affiliation.

@kkt-ee
Copy link

kkt-ee commented Apr 1, 2025

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1007/978-3-030-68763-2_46 is OK
- 10.1007/978-3-030-57077-4_10 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1109/HOTCHIPS.2008.7476520 is OK
- 10.1109/ICASSP49660.2025.10890832 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: TensorFlow: Large-scale machine learning on hetero...
- No DOI given, and none found for title:  TensorFlow: Large-Scale Machine Learning on Heter...
- No DOI given, and none found for title: tensorflow-wavelets: Tensorflow wavelet Layers
- No DOI given, and none found for title: pytorch-wavelets: A port of the DTCWT toolbox to r...
- No DOI given, and none found for title: Wavelet toolbox

❌ MISSING DOIs

- None

❌ INVALID DOIs

- doi.org/10.21105/joss.01237 is INVALID because of 'doi.org/' prefix

@kkt-ee
Copy link

kkt-ee commented Apr 1, 2025

@editorialbot check references

@kkt-ee
Copy link

kkt-ee commented Apr 1, 2025

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

⚠️ An error happened when generating the pdf. Author (Kishore K. Tarafdar) is missing affiliation.

@kkt-ee
Copy link

kkt-ee commented Apr 1, 2025

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

@kkt-ee
Copy link

kkt-ee commented Apr 1, 2025

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

WaveletsExt.jl: Extending the boundaries of wavelets in Julia
Submitting author: @ShozenD
Handling editor: @bmcfee (Active)
Reviewers: @lostanlen, @malmaud
Similarity score: 0.6015

WrightTools: a Python package for multidimensional spectroscopy
Submitting author: @untzag
Handling editor: @yochannah (Retired)
Reviewers: @daissi, @ivergara
Similarity score: 0.5905

TensorFlow.jl: An Idiomatic Julia Front End for TensorFlow
Submitting author: @malmaud
Handling editor: @arokem (Retired)
Reviewers: @jekbradbury
Similarity score: 0.5894

adrt: approximate discrete Radon transform for Python
Submitting author: @karlotness
Handling editor: @diehlpk (Active)
Reviewers: @zhangjy-ge, @fruzsinaagocs
Similarity score: 0.5871

IDTxl: The Information Dynamics Toolkit xl: a Python package for the efficient analysis of multivariate information dynamics in networks
Submitting author: @pwollstadt
Handling editor: @cMadan (Retired)
Reviewers: @danielemarinazzo, @Autoplectic
Similarity score: 0.5778

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@kkt-ee
Copy link

kkt-ee commented Apr 1, 2025

👋 @danielskatz Thank you for pointing out the issues. I've resolved them and updated the repo.

@danielskatz
Copy link

@editorialbot query scope

@editorialbot
Copy link
Collaborator Author

Submission flagged for editorial review.

@editorialbot editorialbot added the query-scope Submissions of uncertain scope for JOSS label Apr 1, 2025
@danielskatz
Copy link

👋 @kkt-ee - I'm sorry to say that after discussion amongst the JOSS editors, we have decided that this submission does not meet the substantial scholarly effort criterion for review by JOSS. Please see https://joss.readthedocs.io/en/latest/submitting.html#other-venues-for-reviewing-and-publishing-software-packages for other suggestions for how you might receive credit for your work.

@danielskatz
Copy link

@editorialbot reject

@editorialbot
Copy link
Collaborator Author

Paper rejected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review query-scope Submissions of uncertain scope for JOSS rejected Track: 7 (CSISM) Computer science, Information Science, and Mathematics
Projects
None yet
Development

No branches or pull requests

3 participants