Skip to content

[PRE REVIEW]: gliderad2cp: A Python package to process Nortek AD2CP velocity profiles from gliders #7924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
editorialbot opened this issue Mar 18, 2025 · 24 comments
Assignees
Labels
pre-review Track: 6 (ESE) Earth Sciences and Ecology

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Mar 18, 2025

Submitting author: @bastienqueste (Bastien Queste)
Repository: https://github.com/bastienqueste/gliderad2cp
Branch with paper.md (empty if default branch):
Version: v0.0.10
Editor: @rwegener2
Reviewers: Pending
Managing EiC: Kristen Thyng

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/c0ce18700a860bf6083fa89b0dd01ae1"><img src="https://joss.theoj.org/papers/c0ce18700a860bf6083fa89b0dd01ae1/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/c0ce18700a860bf6083fa89b0dd01ae1/status.svg)](https://joss.theoj.org/papers/c0ce18700a860bf6083fa89b0dd01ae1)

Author instructions

Thanks for submitting your paper to JOSS @bastienqueste. Currently, there isn't a JOSS editor assigned to your paper.

@bastienqueste if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 6 (ESE) Earth Sciences and Ecology labels Mar 18, 2025
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1109/CWTM.2015.7098134 is OK
- 10.1175/1520-0426(2002)019<0794:DVPULA>2.0.CO;2 is OK
- 10.1175/JTECH-D-16-0156.1 is OK
- 10.5281/zenodo.7416126 is OK

🟡 SKIP DOIs

- None

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.98  T=0.03 s (955.0 files/s, 150077.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                           7            351            592            870
YAML                             5             31              4            172
Markdown                         6             70              0            151
Jupyter Notebook                 2              0           1440            147
reStructuredText                 2             90             28            131
TOML                             1              6              0             70
TeX                              1              3              0             41
Text                             2              0              0             26
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            27            555           2071           1617
-------------------------------------------------------------------------------

Commit count by author:

    73	Callum Rollo
    25	Bastien Y. Queste
     6	Bastien Queste

@editorialbot
Copy link
Collaborator Author

Paper file info:

⚠️ Wordcount for paper.md is 1262

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

RESOURCECODE: A Python package for statistical analysis of sea-state hindcast data
Submitting author: @NRaillard
Handling editor: @marcosvital (Active)
Reviewers: @krober10nd, @platipodium, @malmans2
Similarity score: 0.7159

nctoolkit: A Python package for netCDF analysis and post-processing
Submitting author: @robertjwilson
Handling editor: @martinfleis (Active)
Reviewers: @malmans2, @platipodium
Similarity score: 0.7087

sandpyper: A Python package for UAV-SfM beach volumetric and behavioural analysis
Submitting author: @npucino
Handling editor: @crvernon (Active)
Reviewers: @dbuscombe-usgs, @chrisleaman
Similarity score: 0.7035

OceanSpy: A Python package to facilitate ocean model data analysis and visualization
Submitting author: @malmans2
Handling editor: @kthyng (Active)
Reviewers: @tomchor, @platipodium
Similarity score: 0.7029

flowTorch - a Python library for analysis and reduced-order modeling of fluid flows
Submitting author: @AndreWeiner
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @akaptano, @JaroslavHron, @salrm8, @hkjeldsberg
Similarity score: 0.6991

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@kthyng
Copy link

kthyng commented Mar 18, 2025

Hi @bastienqueste and thanks for your submission! I am looking for some specific items to make sure your submission fits our requirements at a high level (not at the more detailed review level) before moving on to finding an editor or putting this on our waitlist if no relevant editors are available. I'll comment over time as I have a chance to go through them:

In the meantime, please take a look at the comments above ⬆️ from the editorialbot to address any DOI, license, or paper issues if you're able (there may not be any), or suggest reviewers. For reviewers, please suggest 5 reviewers from the database listed above or your own (non-conflicted) extended network. Their github handles are most useful to receive but please don't use "@" to reference them since it will prematurely ping them.

@bastienqueste
Copy link

Hi @kthyng !

It should hopefully tick all of those boxes, all are included. Only minor deviation is our word count is a little over (1262 words) and we'd love it if that could be accepted.

For reviewers, I would suggest from the database, in diminishing order of relevance:
richardsc (highly relevant)
rcaneill
dankelle
DamienIrving

And not from the database:
JGradone (highly relevant)
truedichotomy (highly relevant)
AnthonyBosse (highly relevant)
lnferris (highly relevant)
nbronikowski
soerenthomsen

Hope this helps!

B

@bastienqueste
Copy link

We also had an issue pushing to PyPI so the relevant version is actually v0.0.10 rather than v0.0.9 now.

@kthyng
Copy link

kthyng commented Apr 25, 2025

@editorialbot set v0.0.10 as version

@editorialbot
Copy link
Collaborator Author

Done! version is now v0.0.10

@kthyng
Copy link

kthyng commented Apr 25, 2025

I am going to ping our editorial board to see if this submission passes our criteria for substantial scholarly effort. This process will take a few weeks; thanks for your patience.

@kthyng
Copy link

kthyng commented Apr 25, 2025

@editorialbot query scope

@editorialbot
Copy link
Collaborator Author

Submission flagged for editorial review.

@editorialbot editorialbot added the query-scope Submissions of uncertain scope for JOSS label Apr 25, 2025
@kthyng
Copy link

kthyng commented May 5, 2025

Ok we can move forward with this @bastienqueste!

@kthyng kthyng removed the query-scope Submissions of uncertain scope for JOSS label May 5, 2025
@kthyng
Copy link

kthyng commented May 5, 2025

@editorialbot invite @rwegener2 as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@kthyng
Copy link

kthyng commented May 5, 2025

@rwegener2 Can you edit this submission?

@rwegener2
Copy link

@editorialbot add me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @rwegener2 is now the editor

@rwegener2
Copy link

Hi @bastienqueste 👋🏻 My name is Rachel and I'll be your editor for this submission. If you have questions at any point in the submission process please don't hesitate to reach out!

@rwegener2
Copy link

👋🏻 @nbronikowski or @truedichotomy, would you be willing to review this submission for JOSS? JOSS is an open source journal for scientific research software. We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@nbronikowski
Copy link

Yes - how much time do I have?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Track: 6 (ESE) Earth Sciences and Ecology
Projects
None yet
Development

No branches or pull requests

5 participants