Skip to content

[PRE REVIEW]: GroLink: A general application programming interface for the plant-modeling platform GroIMP #7846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
editorialbot opened this issue Feb 25, 2025 · 35 comments
Assignees
Labels

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Feb 25, 2025

Submitting author: @tim12312 (Tim Oberländer)
Repository: https://gitlab.com/grogra/groimp-plugins/api
Branch with paper.md (empty if default branch):
Version: 1.6
Editor: @rwegener2
Reviewers: Pending
Managing EiC: Kristen Thyng

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/8fe535f7fa1a4f0010f68a2248f7d4b1"><img src="https://joss.theoj.org/papers/8fe535f7fa1a4f0010f68a2248f7d4b1/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/8fe535f7fa1a4f0010f68a2248f7d4b1/status.svg)](https://joss.theoj.org/papers/8fe535f7fa1a4f0010f68a2248f7d4b1)

Author instructions

Thanks for submitting your paper to JOSS @tim12312. Currently, there isn't a JOSS editor assigned to your paper.

@tim12312 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 6 (ESE) Earth Sciences and Ecology labels Feb 25, 2025
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 11858/00-1735-0000-0006-B10B-A is OK
- 10.1109/PMA.2012.6524856 is OK
- 10.1071/FP08084 is OK
- 10.1145/3208854.3208875 is OK
- 10.1109/FSPMA.2016.7818307 is OK
- 10.1093/insilicoplants/diab024 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Rchart — A Chart Plugin For GroIMP Based On R/gg2p...
- No DOI given, and none found for title: Entwicklung eines Video-Export Plugins für die Mod...
- No DOI given, and none found for title: Rule-based integration of LIGNUM into GroIMP
- No DOI given, and none found for title: Design and implementation of a graph grammar based...
- No DOI given, and none found for title: Conveying the Effects of Climate Change
- No DOI given, and none found for title: Interactive procedural forest in game engine envir...
- No DOI given, and none found for title: GroLink: implementing and testing a general applic...
- No DOI given, and none found for title: Godot Engine - Free and open source 2D and 3D game...

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.98  T=0.03 s (1173.0 files/s, 171804.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Java                            13            340            183           1666
JSON                             2              7              0            959
Markdown                         3            459              0            569
XML                              6             10              2            184
Maven                            1              9              0            119
TeX                              1             11              0            118
INI                              3              0              0             16
Ant                              1              3              0             12
Properties                       1              5              0              8
YAML                             1              0              0              7
-------------------------------------------------------------------------------
SUM:                            32            844            185           3658
-------------------------------------------------------------------------------

Commit count by author:

    21	Gaetan Heidsieck
    12	tim
    10	Tim Oberländer
     7	Tim
     3	gaetan heidsieck

@editorialbot
Copy link
Collaborator Author

Paper file info:

⚠️ Wordcount for paper.md is 1333

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

PlantSimEngine: A Simulation Engine For The Soil-Plant-Atmosphere System
Submitting author: @VEZY
Handling editor: @crvernon (Active)
Reviewers: @ashiklom, @tpoisot, @tomyun
Similarity score: 0.6703

GIMS: Graphical Interface for Materials Simulations
Submitting author: @kokookster
Handling editor: @jgostick (Active)
Reviewers: @marshallmcdonnell, @jgostick
Similarity score: 0.6693

CGIMP: Real-time exploration and covariate projection for self-organizing map datasets
Submitting author: @adadiehl
Handling editor: @lpantano (Active)
Reviewers: @adriancbondia, @ @arunhpatil, @arunhpatil
Similarity score: 0.6611

glottospace: R package for language mapping and geospatial analysis of linguistic and cultural data
Submitting author: @SietzeN
Handling editor: @ajstewartlang (Active)
Reviewers: @fauxneticien, @skalyan91
Similarity score: 0.6607

Cacatoo: building, exploring, and sharing spatially structured models of biological systems
Submitting author: @bramvandijk88
Handling editor: @Bisaloo (Retired)
Reviewers: @emilydolson, @TimKam
Similarity score: 0.6590

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@kthyng
Copy link

kthyng commented Feb 25, 2025

Hi @tim12312! You said in your note that there are Python and R client libraries. Are those meant to be reviewed with this submission and if so where are they located?

@tim12312
Copy link

Hi @kthyng The libraries are used in the presented examples and therefore are part of the submission. They can be found here:

@kthyng
Copy link

kthyng commented Apr 17, 2025

Hi @tim12312 and thanks for your submission! I am looking for some specific items to make sure your submission fits our requirements at a high level (not at the more detailed review level) before moving on to finding an editor or putting this on our waitlist if no relevant editors are available. I'll comment over time as I have a chance to go through them:

In the meantime, please take a look at the comments above ⬆️ from the editorialbot to address any DOI, license, or paper issues if you're able (there may not be any), or suggest reviewers. For reviewers, please suggest 5 reviewers from the database listed above or your own (non-conflicted) extended network. Their github handles are most useful to receive but please don't use "@" to reference them since it will prematurely ping them.

@kthyng
Copy link

kthyng commented Apr 17, 2025

@tim12312 Your paper is on the long end. Please shorten it by 200-300 words please.

@rwegener2 Could you edit this submission?

@kthyng
Copy link

kthyng commented Apr 17, 2025

@editorialbot invite @rwegener2 as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@rwegener2
Copy link

@editorialbot add me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @rwegener2 is now the editor

@rwegener2
Copy link

👋🏻 @antoineruzette and @AnjaConev, would you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@tim12312
Copy link

@kthyng I just updated the paper, the length should now be in the range.

@AnjaConev
Copy link

Hi @rwegener2 I'm afraid this work is outside of the scope of my expertise and I thus have to decline. Cheers

@rwegener2
Copy link

No problem, thanks for the reply!

@rwegener2
Copy link

rwegener2 commented Apr 24, 2025

@tim12312 I will continue to search for reviewers, but would you also please suggest 3-5 potential reviewers for this submission? You can list their Github handles without the @ sign, so they do not get tagged yet. Thank you!

@rwegener2
Copy link

👋🏻 @oparisot and @sebastian-raubach, would you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@oparisot
Copy link

@rwegener2 It's not directly my field of expertise, I would suggest to find an other reviewer for this specific submission!

@sebastian-raubach
Copy link

@rwegener2 Similar to oparisot, this falls outwith my expertise, so I'd be reluctant to agree to be a reviewer.

@rwegener2
Copy link

👋🏻 @arbennett, would you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

I see you are already reviewing a submission at the moment, but I'm happy to extend the usual timeframe for reviews to accommodate that.

@rwegener2
Copy link

👋🏻 @iimog, would you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

I see you are already reviewing a submission at the moment, but I'm happy to extend the usual timeframe for reviews to accommodate that.

@rwegener2
Copy link

No worries, thanks for the response @oparisot and @sebastian-raubach!

@iimog
Copy link

iimog commented May 5, 2025

Thanks @rwegener2 for the invitation. While the project looks interesting, I'm afraid, I don't have the proper expertise to provide a timely review.

@arbennett
Copy link

@rwegener2 - sorry to also bail, but I am already in the process of doing 3 other reviews at the moment so don't have capacity. Thanks for the invitation to review though!

@rwegener2
Copy link

No problem @iimog and @arbennett. Thanks for the timely reply!

@rwegener2
Copy link

rwegener2 commented May 6, 2025

👋🏻 @VEZY, would you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

The repository linked above is in Java, but there are also client libraries in Python and R that are part of the review:

@rwegener2
Copy link

rwegener2 commented May 6, 2025

👋🏻 @jtagusari, would you be willing to review this submission for JOSS? We are looking for a reviewer with knowledge of Java. We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@jtagusari
Copy link

@rwegener2 Thank you for the offer. However, I am not very familiar with java and have been very busy lately, so I don't think I will have the time to get involved. I would like to decline this offer.

@rwegener2
Copy link

No problem @jtagusari, thanks for the speedy reply!

@rwegener2
Copy link

👋🏻 @egonw, would you be willing to review this submission for JOSS? We are looking for a reviewer with knowledge of Java. We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@egonw
Copy link

egonw commented May 7, 2025

would you be willing to review this submission for JOSS?

@rwegener2, yes, accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests