-
-
Notifications
You must be signed in to change notification settings - Fork 41
[PRE REVIEW]: CtrlAer: A MicroPython package and embedded domain specific language for real-time control of piezoelectric atomisers #7566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: 🔴 Failed to discover a valid open source license |
Five most similar historical JOSS papers: py-opc: operate the Alphasense OPC-N2 from a raspberry pi or other popular microcontrollers/microcomputers Pybehave: a hardware agnostic, Python-based framework for controlling behavioral neuroscience experiments MAHOS: Measurement Automation Handling and Orchestration System Pyrokinetics - A Python library to standardise gyrokinetic analysis chombo-discharge: An AMR code for gas discharge simulations in complex geometries |
Potential reviewers: mjwilkins18, ktahar, finsberg Also added license file. |
@editorialbot commands |
Hello @hessammehr, here are the things you can ask me to do:
|
@hessammehr thanks for your submission to JOSS. Unfortunately, given its small size and limited functionality, this submission doesn't meet our substantial scholarly effort criterion. One possible alternative to JOSS is to follow GitHub's guide on how to create a permanent archive and DOI for your software. This DOI can then be used by others to cite your work. We will now proceed to reject this submission. Note that the above conclusion does not mean the work is not useful or of a bad quality, it simply means it is not in scope for JOSS based on the above criteria. |
@editorialbot reject |
Paper rejected. |
@Kevin-Mattheus-Moerman thanks for this feedback. In terms of meeting substantial scholarly effort criteria with respect to size, I would be interested to know whether the embedded nature of this project has been taken into account. Due to limited resources on the target device and specifically the PIO machinery, projects of this nature will inherently be smaller in size, despite the significant technical challenge, in this case to achieve correct, gap-free operation via the state machines. Functionality-wise as well, this software has already enabled a recent academic publication with more projects underway or under review. It can be used to control a range of laboratory equipment where no high-level programmable options currently exist. Finally, the development and experimental testing of this package has been a focus in our group over the last six months, something perhaps not directly reflected by the commit count as most development/testing primarily took place on-device. I would be grateful for the opportunity to include this contribution in the peer review process. I also appreciate that the hardware focus of this work may complicate editorial assessment from a scientific computing point of view, in which case a second independent assessment would be greatly appreciated. |
Submitting author: @hessammehr (S. Hessam M. Mehr)
Repository: https://github.com/MehrResearch/ctrlaer/
Branch with paper.md (empty if default branch): paper
Version: 0.2.0
Editor: Pending
Reviewers: Pending
Managing EiC: Kevin M. Moerman
Status
Status badge code:
Author instructions
Thanks for submitting your paper to JOSS @hessammehr. Currently, there isn't a JOSS editor assigned to your paper.
@hessammehr if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.
Editor instructions
The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:
The text was updated successfully, but these errors were encountered: