Skip to content

[PRE REVIEW]: aiida-aimall: A Python package for automating workflows for AIMAll software #7462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
editorialbot opened this issue Nov 12, 2024 · 27 comments
Assignees
Labels
pre-review Python TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Nov 12, 2024

Submitting author: @kmlefran (Kevin Lefrancois-Gagnon)
Repository: https://github.com/kmlefran/aiida-aimall
Branch with paper.md (empty if default branch): paper
Version: v1.0.1
Editor: @HaoZeke
Reviewers: @mkphuthi
Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/d342e23c5e1f7bd3bc9ae8ddfe2f7649"><img src="https://joss.theoj.org/papers/d342e23c5e1f7bd3bc9ae8ddfe2f7649/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/d342e23c5e1f7bd3bc9ae8ddfe2f7649/status.svg)](https://joss.theoj.org/papers/d342e23c5e1f7bd3bc9ae8ddfe2f7649)

Author instructions

Thanks for submitting your paper to JOSS @kmlefran. Currently, there isn't a JOSS editor assigned to your paper.

@kmlefran if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials labels Nov 12, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1038/s41597-020-00638-4 is OK
- 10.1021/acs.jcim.3c00987 is OK
- 10.5281/zenodo.8304939 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Gaussian˜16 Revision C.01

❌ MISSING DOIs

- Entry without DOI or title found

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.27 s (243.1 files/s, 48639.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          26            723           1297           3298
Markdown                         5            186              0            536
Jupyter Notebook                 8              0           3978            358
YAML                            10             38             21            300
TOML                             1             18              4            150
reStructuredText                12            905           1013            130
CSS                              1              8              4            118
TeX                              1              0              0             71
make                             1             10              8             23
Bourne Shell                     1              0              0              6
-------------------------------------------------------------------------------
SUM:                            66           1888           6325           4990
-------------------------------------------------------------------------------

Commit count by author:

   384	kmlefran
     7	Kevin Lefrancois-Gagnon

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 987

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

excitingtools: An exciting Workflow Tool
Submitting author: @AlexBuccheri
Handling editor: @richardjgowers (Retired)
Reviewers: @fjmartinmartinez, @hmacdope
Similarity score: 0.7396

kiwiPy: Robust, high-volume, messaging for big-data and computational science workflows
Submitting author: @muhrin
Handling editor: @danielskatz (Active)
Reviewers: @dghoshal-lbl, @uellue
Similarity score: 0.7336

Interface to high-performance periodic coupled-cluster theory calculations with atom-centered, localized basis functions
Submitting author: @Evmoerman
Handling editor: @rkurchin (Active)
Reviewers: @awvwgk, @wcwitt
Similarity score: 0.7279

GIMS: Graphical Interface for Materials Simulations
Submitting author: @kokookster
Handling editor: @jgostick (Active)
Reviewers: @marshallmcdonnell, @jgostick
Similarity score: 0.7229

Surfaxe: Systematic surface calculations
Submitting author: @brlec
Handling editor: @danielskatz (Active)
Reviewers: @pzarabadip, @eihernan
Similarity score: 0.7185

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@arfon
Copy link
Member

arfon commented Nov 12, 2024

@kmlefran - thanks for your submission to JOSS. We're currently managing a large backlog of submissions and the editor most appropriate for your area is already rather busy.

For now, we will need to waitlist this paper and process it as the queue reduces. Thanks for your patience!

@arfon arfon added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Nov 12, 2024
@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot invite @HaoZeke as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@Kevin-Mattheus-Moerman
Copy link
Member

@kmlefran Dear author, thanks for this submission. I am the AEiC on this track and here to help process the initial steps. I have just invited an editor. However, before we proceed, please can you have a look at the following points:

  • Your project appears to lack contributing guidelines at the moment. Please work to add these and to mention/link to them in your README. You could for instance create a CONTRIBUTING.md file (see here for some examples: https://contributing.md/example/).

@kmlefran
Copy link

kmlefran commented Dec 4, 2024

@Kevin-Mattheus-Moerman Thanks for informing me. I have added CONTRIBUTING.md and linked to it in the README

@HaoZeke
Copy link
Member

HaoZeke commented Dec 7, 2024

Happy to work on this, thanks for the invite @Kevin-Mattheus-Moerman

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot assign @HaoZeke as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @HaoZeke is now the editor

@Kevin-Mattheus-Moerman Kevin-Mattheus-Moerman removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Feb 6, 2025
@Kevin-Mattheus-Moerman
Copy link
Member

@HaoZeke can you start looking for reviewers for this one? Thanks!

@HaoZeke
Copy link
Member

HaoZeke commented Feb 10, 2025

@imtambovtcev do you think you could review this one?

@HaoZeke
Copy link
Member

HaoZeke commented Feb 10, 2025

@kmlefran sorry for the delay on this, if you have any suggested reviewers please let me know (without @'ing them).

@HaoZeke
Copy link
Member

HaoZeke commented Feb 10, 2025

Hi @mkphuthi 👋 would you be interested in and available to review this JOSS submission? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: joss.readthedocs.io/en/latest/review_criteria.html
From your work on ASIMTools it would be good to have your opinion.

@HaoZeke
Copy link
Member

HaoZeke commented Feb 10, 2025

Hi @BernardoFerreira 👋 would you be interested in and available to review this JOSS submission? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: joss.readthedocs.io/en/latest/review_criteria.html
From your work on CRATE it would be good to have your opinion.

@HaoZeke
Copy link
Member

HaoZeke commented Feb 10, 2025

Actually as an AiiDA plugin it'd also be fantastic to have anyone from @aiidateam take a look if possible.

@mkphuthi
Copy link

Hi @HaoZeke, I can review.

@HaoZeke
Copy link
Member

HaoZeke commented Feb 27, 2025

@editorialbot add @mkphuthi as reviewer

Thanks for stepping up, as soon as we have one more reviewer we can get moving on this.

@editorialbot
Copy link
Collaborator Author

@mkphuthi added to the reviewers list!

@mkphuthi
Copy link

@editorialbot generate my checklist

@editorialbot
Copy link
Collaborator Author

Checklists can only be created once the review has started in the review issue

@HaoZeke
Copy link
Member

HaoZeke commented Apr 9, 2025

Sorry my bad @mkphuthi I need to find one more reviewer.
@Kokookster or @muhrin would you be able to review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Python TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials
Projects
None yet
Development

No branches or pull requests

6 participants