-
-
Notifications
You must be signed in to change notification settings - Fork 41
[REVIEW]: pvpumpingsystem: a python package for modeling and sizing photovoltaic water pumping systems #2637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @samuelduchesne, @robinroche it looks like you're currently assigned to review this paper 🎉. Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
@samuelduchesne and @robinroche thanks for agreeing to review this submission to JOSS. As noted above, we are trying to adjust to authors, reviewers, and editors needs under COVID. Thus we are asking reviewers try and complete reviews in 6 weeks. I am going to use whedon the editorial bot to remind you about your review in three weeks, half way through the requested timeline. If there are any questions from the authors or reviewers throughout the process, please feel free to let me know here or directly at [email protected]. Thanks again for contributing to the JOSS review process. |
@whedon remind @samuelduchesne in three weeks |
Reminder set for @samuelduchesne in three weeks |
@whedon remind @robinroche in three weeks |
Reminder set for @robinroche in three weeks |
👋 @samuelduchesne, please update us on how your review is going. |
👋 @robinroche, please update us on how your review is going. |
Hi, I will work on it next week. Sorry for the delay. |
Still working on it! Thanks |
@robinroche and @samuelduchesne thanks for checking in. As I noted above, the recent reminder marks three weeks into the review and JOSS is asking reviewers to complete reviews in six weeks. Thanks in advance for your contributions to the JOSS review process. |
@tylunel @kbarnhart
Documentation:
Paper:
Results of the test script: ============================================ test session starts ============================================ pvpumpingsystem/test/test_pump.py ....... [ 43%] ============================================= warnings summary ============================================== pvpumpingsystem/test/test_pump.py::test_init pvpumpingsystem/test/test_pump.py::test_limited_pump_data_1 pvpumpingsystem/test/test_pump.py::test_limited_pump_data_2 pvpumpingsystem/test/test_pump.py::test_functIforVH pvpumpingsystem/test/test_pump.py::test_functIforVH pvpumpingsystem/test/test_pump.py::test_functIforVH pvpumpingsystem/test/test_sizing.py::test_sizing_minimize_npv_mppt pvpumpingsystem/test/test_sizing.py::test_sizing_minimize_npv_mppt pvpumpingsystem/test/test_sizing.py::test_sizing_minimize_npv_direct -- Docs: https://docs.pytest.org/en/latest/warnings.html |
@kbarnhart, I am done with the review as well. On my end, I worked on MacOS and had no issues installing and using the tool from the installation documentation. I enjoyed trying out this package which is very well coded (excellent programming ethics). The examples were very useful to understand how to use the package. Having both jupyter notebooks and python scripts in the examples folder is a welcomed feature. Regarding installation, my only suggestion would be to upload the package to PyPi (or to conda-forge) so that a regular I agree with @robinroche's suggestions for improvement which cover most of the package-related considerations. I do have general comments as well as some questions regarding the methodology the tool implements (which should not be overlooked...). I present them bellow. Scope
Mention of "minimization"There is very little information in the docs as well as in the paper about the kind of optimization that is performed in the sizing module.
Also, the hardcoded values of 45° and 180° for the PV surface tilt and azimuth in
|
@kbarnhart |
Thanks for you very constructive comments @samuelduchesne @robinroche ! I will address the points you raise and come back to you with the corresponding improvements. But before I have two questions. The first is about the warnings in the tests:
I am not sure what is the best practice here, and unfortunately internet did not provide a clear answer on it either haha. I added several warnings in my code in order to guide the user during a normal simulation or sizing, but this results in having all these warnings in the tests as well. Should I try not to add as much The second question in actually more a request for clarification to @robinroche :
What does this "Getting started" page should contain more exactly in your opinion? Help on how to run the python and jupyter notebook examples? More general explanations around what is a PV pumping system (so far, I assume that the users have a minimum knowledge about PV pumping systems)? A more abstract layout of the steps of simulation than what is proposed in the examples? Thanks in advance for providing further details |
@robinroche and @samuelduchesne Thanks for your thoughtful reviews! At this point in the JOSS process we will now let @tylunel address these issues. If more extensive discussion needs to take place I would recommend that @tylunel make an issue in the submitted repository, paste and link to the above review comments, and focus the discussion there. This makes it easier to keep track of multiple threads. I'll weigh in briefly regarding two items.
Regarding other warnings (e.g., RuntimeWarning, DeprecationWarning), there are lots of options for warning handling in testing tools (I'm mostly familiar with those in pytest) but I think that how one uses them is a matter of developer preference (e.g., you could turn them all off using a configuration file, but perhaps you want to know when DeprecationWarnings arrive). Ultimately this means that it is important for the developer to communicate to someone who might use the tests about what they should see. Happy to discuss these and other points. Please let me know how I can assist as you respond and clarify reviewer comments. |
@tylunel Yes, I was thinking of a high level explanation of how to use the code, and pointing the user to the basic example at the end of the installation.
@tylunel I agree with @kbarnhart . I did not notice anything worrying in the warnings, but I think that the user should know that getting these warnings may be normal. Otherwise one may wonder if the code will be fully operational or not. |
The changes have been made as proposed in the reviews. I hope that it corresponds well to your expectations @robinroche @samuelduchesne. There is one point that was maybe not addressed completely as expected, it is for the clear definition of the 2 use cases (penultimate item of @samuelduchesne). On that, I did not want to insist too much on the sizing case, as it is not the core of the package. The modeling tools are the core, and the sizing tool proposed is more a wrapper of the previous tools, and should be more seen as an example of how the code can be used to adress complex problems. I tried to clarify it in the docs as well. For the rest of the modifications, there were all useful I think, thanks! |
@tylunel Thanks, my comments have been addressed. Congratulations on this package that will hopefully be useful to many. |
Thank you @tylunel for addressing these comments. I have nothing to add 😀 |
@robinroche and @samuelduchesne thank you for your thoughtful comments and timely review. @tylunel thank you for responding to the reviewer comments. Now that the reviewers have completed the checklist and recommended publication the next step is that I will do a final proofreading step on the publication (I may make a PR or just provide a list). This will happen in the next few days. Once that is complete I will ask @tylunel to complete a few steps to create the final archive and will then pass the submission on to the JOSS Editors in Chief for final processing. |
@tylunel it looks like there is an issue with the paper.md file that makes it not compile. Would you address it and then ping me so I can proceed. If you make changes on a test branch, know that you can use whedon to compile off a custom branch:
|
@kbarnhart Sorry for that, I forgot to check the encoding in UTF-8 after the last changes in paper.md. |
@whedon generate pdf |
@whedon generate pdf |
@tylunel thanks for merging those copyedits. Congratulations on making to the end of the JOSS review process. At this point could you:
I can then move forward with accepting the submission. |
The release version is v1.0.0 (https://github.com/tylunel/pvpumpingsystem/releases/tag/v1.0.0) and the DOI of the archive version is 10.5281/zenodo.4134280 (https://zenodo.org/record/4134280). |
@whedon set v1.0.0 as version |
OK. v1.0.0 is the version. |
@whedon set 10.5281/zenodo.4134280 as archive |
OK. 10.5281/zenodo.4134280 is the archive. |
@whedon accept |
|
|
@tylunel this is now in the hands of the JOSS handling Editor in Chief who manages final publication. |
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#1864 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1864, then you can now move forward with accepting the submission by compiling again with the flag
|
@whedon accept deposit=true |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@samuelduchesne, @robinroche - many thanks for your reviews here and to @kbarnhart for editing this submission ✨ @tylunel - your paper is now accepted into JOSS ⚡🚀💥 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
A big thank you to all! I wish you all the best :D |
Submitting author: @tylunel (Tanguy Lunel)
Repository: https://github.com/tylunel/pvpumpingsystem
Version: v1.0.0
Editor: @kbarnhart
Reviewer: @samuelduchesne, @robinroche
Archive: 10.5281/zenodo.4134280
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@samuelduchesne & @robinroche, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @kbarnhart know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Review checklist for @samuelduchesne
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @robinroche
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
The text was updated successfully, but these errors were encountered: