fix: Fixes according to designer feedback

Author: PavloNetrebchuk

app/src/main/res/color/bottom_nav_color.xml

@@ -0,0 +1,5 @@
+<?xml version="1.0" encoding="utf-8"?>
+<selector xmlns:android="http://schemas.android.com/apk/res/android">
+    <item android:state_checked="true" android:color="@color/checked_tab_item" />
+    <item android:state_checked="false" android:color="@color/unchecked_tab_item" />
+</selector>

app/src/main/res/layout/fragment_main.xml

@@ -14,17 +14,17 @@
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintTop_toTopOf="parent" />
 
-
     <com.google.android.material.bottomnavigation.BottomNavigationView
         android:id="@+id/bottom_nav_view"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
+        app:itemIconTint="@color/bottom_nav_color"
+        app:itemTextColor="@color/bottom_nav_color"
         app:labelVisibilityMode="labeled"
         app:layout_constraintBottom_toBottomOf="parent"
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintHorizontal_bias="0.5"
         app:layout_constraintStart_toStartOf="parent"
         app:menu="@menu/bottom_view_menu" />
 
-
 </androidx.constraintlayout.widget.ConstraintLayout>

core/src/main/java/org/openedx/core/ui/ComposeCommon.kt

@@ -49,6 +49,7 @@ import androidx.compose.material.TextFieldDefaults
 import androidx.compose.material.icons.Icons
 import androidx.compose.material.icons.filled.AccountCircle
 import androidx.compose.material.icons.filled.Close
+import androidx.compose.material.icons.filled.ManageAccounts
 import androidx.compose.material.icons.filled.Search
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.LaunchedEffect
@@ -200,8 +201,8 @@ fun Toolbar(
                 onClick = { onSettingsClick() }
             ) {
                 Icon(
-                    painter = painterResource(id = R.drawable.core_ic_settings),
-                    tint = MaterialTheme.appColors.primary,
+                    imageVector = Icons.Default.ManageAccounts,
+                    tint = MaterialTheme.appColors.textAccent,
                     contentDescription = stringResource(id = R.string.core_accessibility_settings)
                 )
             }

core/src/main/res/values-night/colors.xml

@@ -3,4 +3,6 @@
     <color name="background">#FF19212F</color>
     <color name="primary">#5478F9</color>
     <color name="splash">#19212F</color>
+    <color name="checked_tab_item">#879FF5</color>
+    <color name="unchecked_tab_item">#8E9BAE</color>
 </resources>

core/src/main/res/values/colors.xml

@@ -3,4 +3,6 @@
     <color name="background">#FFFFFF</color>
     <color name="primary">#3C68FF</color>
     <color name="splash">#517BFE</color>
+    <color name="checked_tab_item">#3C68FF</color>
+    <color name="unchecked_tab_item">#97A5BB</color>
 </resources>

dashboard/src/main/java/org/openedx/courses/presentation/PrimaryCourseScreen.kt

@@ -677,7 +677,9 @@ private fun PrimaryCourseTitle(
             modifier = Modifier.fillMaxWidth(),
             text = primaryCourse.course.name,
             style = MaterialTheme.appTypography.titleLarge,
-            color = MaterialTheme.appColors.textDark
+            color = MaterialTheme.appColors.textDark,
+            overflow = TextOverflow.Ellipsis,
+            maxLines = 3
         )
         Text(
             modifier = Modifier.fillMaxWidth(),

dashboard/src/main/java/org/openedx/learn/presentation/LearnFragment.kt

@@ -2,6 +2,7 @@ package org.openedx.learn.presentation
 
 import android.os.Bundle
 import android.view.View
+import androidx.compose.animation.core.animateFloatAsState
 import androidx.compose.foundation.ExperimentalFoundationApi
 import androidx.compose.foundation.background
 import androidx.compose.foundation.clickable
@@ -20,6 +21,7 @@ import androidx.compose.material.MaterialTheme
 import androidx.compose.material.Text
 import androidx.compose.material.icons.Icons
 import androidx.compose.material.icons.filled.ExpandMore
+import androidx.compose.material.icons.filled.ManageAccounts
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.LaunchedEffect
 import androidx.compose.runtime.getValue
@@ -28,9 +30,9 @@ import androidx.compose.runtime.remember
 import androidx.compose.runtime.setValue
 import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
+import androidx.compose.ui.draw.rotate
 import androidx.compose.ui.graphics.Color
 import androidx.compose.ui.platform.LocalContext
-import androidx.compose.ui.res.painterResource
 import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.tooling.preview.Preview
 import androidx.compose.ui.unit.Dp
@@ -157,8 +159,8 @@ private fun Title(
             }
         ) {
             Icon(
-                painter = painterResource(id = CoreR.drawable.core_ic_settings),
-                tint = MaterialTheme.appColors.primary,
+                imageVector = Icons.Default.ManageAccounts,
+                tint = MaterialTheme.appColors.textAccent,
                 contentDescription = stringResource(id = CoreR.string.core_accessibility_settings)
             )
         }
@@ -173,6 +175,10 @@ private fun LearnDropdownMenu(
 ) {
     var expanded by remember { mutableStateOf(false) }
     var currentValue by remember { mutableStateOf(LearnType.COURSES) }
+    val iconRotation by animateFloatAsState(
+        targetValue = if (expanded) 180f else 0f,
+        label = ""
+    )
 
     LaunchedEffect(currentValue) {
         viewPager.setCurrentItem(
@@ -199,6 +205,7 @@ private fun LearnDropdownMenu(
                 style = MaterialTheme.appTypography.titleSmall
             )
             Icon(
+                modifier = Modifier.rotate(iconRotation),
                 imageVector = Icons.Default.ExpandMore,
                 tint = MaterialTheme.appColors.textDark,
                 contentDescription = null

dashboard/src/main/res/values/strings.xml

@@ -9,7 +9,7 @@
     <string name="dashboard_course_date">Course %1$s</string>
     <string name="dashboard_start_course">Start course</string>
     <string name="dashboard_resume_course">Resume Course</string>
-    <string name="dashboard_past_due_assignment">%1$d Past Due Assignment</string>
+    <string name="dashboard_past_due_assignment">%1$d Past Due Assignments</string>
     <string name="dashboard_view_all_with_count">View All (%1$d)</string>
     <string name="dashboard_view_all">View All</string>
     <string name="dashboard_assignment_due_in_days">%1$s Due in %2$s</string>