-
Notifications
You must be signed in to change notification settings - Fork 73
feat: add GTM integration #814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @bydawen! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
IMO you should also add GTM environment configuration. Example:
Copied from my comment on Open edX Forum: https://discuss.openedx.org/t/add-gtm-support-to-open-edx-core/16234/5 |
@@ -290,7 +290,7 @@ export async function initialize({ | |||
analyticsService = SegmentAnalyticsService, | |||
authService = AxiosJwtAuthService, | |||
authMiddleware = [], | |||
externalScripts = [GoogleAnalyticsLoader], | |||
externalScripts = [GoogleAnalyticsLoader, GoogleTagManagerLoader], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we have GoogleAnalyticsLoader
defined here already, it looks like the right place to add support for something like GTM. However, adding support for arbitrary external scripts, however popular, is not really maintainable for the project.
Instead, it would be better if we made externalScripts
configurable via env.config.jsx
, removing Google Analytics support in the process but allowing operators to add any external script they need without requiring the platform to explicitly support it. Is this a change you're comfortable contributing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @arbrandes, thank you for the idea of making externalScripts
configurable!
We'll discuss this approach with our team and may consider creating a separate PR to explore that direction.
For now, I think to keep the current implementation as-is, since in our projects we frequently use GTM in this way. We’d also like to gather more feedback from the community, including real-world examples of GTM usage, to help refine and potentially improve our solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arbrandes thanks for your feedback! Can we go ahead with the changes we have in this PR and create a separate issue to implement the functionality of adding externalScripts
via env.config.jsx
?
@igobranco answered you on forum post, thank's |
@bydawen I've added you to the openedx-triage team as you are covered under an entity CLA. This will mean that tests will run automatically when you submit a pull request in the future. Please look for an invitation in your email and accept it. |
9a10502
to
27b9010
Compare
27b9010
to
1159d23
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #814 +/- ##
==========================================
+ Coverage 86.79% 87.28% +0.48%
==========================================
Files 48 49 +1
Lines 1401 1423 +22
Branches 297 303 +6
==========================================
+ Hits 1216 1242 +26
+ Misses 172 168 -4
Partials 13 13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Open edX forum post with a proposal of the feature:
https://discuss.openedx.org/t/add-gtm-support-to-open-edx-core/16234
This PR is directed to make easier integration of analytics and tracking scripts without modifying the core platform code.
It enables the GTM support, making it more flexible for platform operators to manage tags via the site configuration panel in the admin section of the platform.
If Google Tag Manager ID configured correctly it will appear on the website with corresponding GTM scripts initialisations:
Also we made PR to enable similar support on the legacy parts of edX platform:
edx-platform