Skip to content

feat: add GTM integration #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bydawen
Copy link

@bydawen bydawen commented Jun 5, 2025

Open edX forum post with a proposal of the feature:
https://discuss.openedx.org/t/add-gtm-support-to-open-edx-core/16234

This PR is directed to make easier integration of analytics and tracking scripts without modifying the core platform code.

It enables the GTM support, making it more flexible for platform operators to manage tags via the site configuration panel in the admin section of the platform.

admn_pnl

If Google Tag Manager ID configured correctly it will appear on the website with corresponding GTM scripts initialisations:

1

Also we made PR to enable similar support on the legacy parts of edX platform:
edx-platform

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 5, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Jun 5, 2025

Thanks for the pull request, @bydawen!

This repository is currently maintained by @openedx/committers-frontend.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Jun 5, 2025
@bydawen bydawen marked this pull request as ready for review June 6, 2025 08:17
@igobranco
Copy link

IMO you should also add GTM environment configuration.

Example:

What I want to highlight is the possibility to have custom GTM environments. This is important when you have to manage a complex configuration on GTM. Like test it before on DEV/STAGE environments before publishing to production. Just view our implementation and be inspired by it!

Copied from my comment on Open edX Forum: https://discuss.openedx.org/t/add-gtm-support-to-open-edx-core/16234/5

@@ -290,7 +290,7 @@ export async function initialize({
analyticsService = SegmentAnalyticsService,
authService = AxiosJwtAuthService,
authMiddleware = [],
externalScripts = [GoogleAnalyticsLoader],
externalScripts = [GoogleAnalyticsLoader, GoogleTagManagerLoader],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have GoogleAnalyticsLoader defined here already, it looks like the right place to add support for something like GTM. However, adding support for arbitrary external scripts, however popular, is not really maintainable for the project.

Instead, it would be better if we made externalScripts configurable via env.config.jsx, removing Google Analytics support in the process but allowing operators to add any external script they need without requiring the platform to explicitly support it. Is this a change you're comfortable contributing?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @arbrandes, thank you for the idea of making externalScripts configurable!

We'll discuss this approach with our team and may consider creating a separate PR to explore that direction.

For now, I think to keep the current implementation as-is, since in our projects we frequently use GTM in this way. We’d also like to gather more feedback from the community, including real-world examples of GTM usage, to help refine and potentially improve our solution.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arbrandes thanks for your feedback! Can we go ahead with the changes we have in this PR and create a separate issue to implement the functionality of adding externalScripts via env.config.jsx?

@bydawen
Copy link
Author

bydawen commented Jun 11, 2025

IMO you should also add GTM environment configuration.

Example:

What I want to highlight is the possibility to have custom GTM environments. This is important when you have to manage a complex configuration on GTM. Like test it before on DEV/STAGE environments before publishing to production. Just view our implementation and be inspired by it!

Copied from my comment on Open edX Forum: https://discuss.openedx.org/t/add-gtm-support-to-open-edx-core/16234/5

@igobranco answered you on forum post, thank's

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jun 12, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Needs Tests Run or CLA Signed in Contributions Jun 12, 2025
@e0d
Copy link

e0d commented Jun 12, 2025

@bydawen I've added you to the openedx-triage team as you are covered under an entity CLA. This will mean that tests will run automatically when you submit a pull request in the future. Please look for an invitation in your email and accept it.

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jun 12, 2025
@bydawen
Copy link
Author

bydawen commented Jun 13, 2025

@bydawen I've added you to the openedx-triage team as you are covered under an entity CLA. This will mean that tests will run automatically when you submit a pull request in the future. Please look for an invitation in your email and accept it.

@e0d Thank you!

@mphilbrick211 mphilbrick211 moved this from Needs Tests Run or CLA Signed to Waiting on Author in Contributions Jun 16, 2025
@bydawen bydawen force-pushed the rg/gtm-support-mfe branch from 9a10502 to 27b9010 Compare July 7, 2025 15:21
@bydawen bydawen force-pushed the rg/gtm-support-mfe branch from 27b9010 to 1159d23 Compare July 7, 2025 15:28
Copy link

codecov bot commented Jul 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.28%. Comparing base (93bee06) to head (1159d23).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #814      +/-   ##
==========================================
+ Coverage   86.79%   87.28%   +0.48%     
==========================================
  Files          48       49       +1     
  Lines        1401     1423      +22     
  Branches      297      303       +6     
==========================================
+ Hits         1216     1242      +26     
+ Misses        172      168       -4     
  Partials       13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Waiting on Author
Development

Successfully merging this pull request may close these issues.

7 participants