Skip to content

Commit b422c87

Browse files
feat: ora mobile responsive
1 parent 64b57df commit b422c87

File tree

8 files changed

+31
-77
lines changed

8 files changed

+31
-77
lines changed

src/components/InfoPopover/__snapshots__/index.test.jsx.snap

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ exports[`Info Popover Component snapshot 1`] = `
1515
</Popover.Content>
1616
</Popover>
1717
}
18-
placement="right-end"
18+
placement="left-end"
1919
trigger="focus"
2020
>
2121
<IconButton

src/components/InfoPopover/index.jsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import messages from './messages';
2020
export const InfoPopover = ({ onClick, children, intl }) => (
2121
<OverlayTrigger
2222
trigger="focus"
23-
placement="right-end"
23+
placement="left-end"
2424
flip
2525
overlay={(
2626
<Popover id="info-popover" className="overlay-help-popover">

src/containers/ListView/ListView.scss

+10
Original file line numberDiff line numberDiff line change
@@ -25,4 +25,14 @@ span.pgn__icon.breadcrumb-arrow {
2525
margin-bottom: 0;
2626
}
2727
}
28+
29+
@include media-breakpoint-down(xs) {
30+
.badge {
31+
white-space: normal;
32+
}
33+
34+
.pgn__table-actions > div:first-of-type {
35+
z-index: $zindex-modal !important;
36+
}
37+
}
2838
}

src/containers/ReviewActions/ReviewActions.scss

+7-1
Original file line numberDiff line numberDiff line change
@@ -34,4 +34,10 @@
3434
.review-actions-username {
3535
padding-bottom: map-get($spacers, 3);
3636
}
37-
}
37+
}
38+
39+
@include media-breakpoint-down(xs) {
40+
.overlay-help-popover {
41+
max-width: calc(100% - 60px) !important;
42+
}
43+
}

src/containers/ReviewActions/__snapshots__/index.test.jsx.snap

+3-3
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ exports[`ReviewActions component component snapshot: do not show rubric 1`] = `
1818
status="grading-status"
1919
/>
2020
<span
21-
className="small"
21+
className="small text-nowrap"
2222
>
2323
<FormattedMessage
2424
defaultMessage="Score: {pointsEarned}/{pointsPossible}"
@@ -73,7 +73,7 @@ exports[`ReviewActions component component snapshot: loading 1`] = `
7373
status="grading-status"
7474
/>
7575
<span
76-
className="small"
76+
className="small text-nowrap"
7777
>
7878
<FormattedMessage
7979
defaultMessage="Score: {pointsEarned}/{pointsPossible}"
@@ -115,7 +115,7 @@ exports[`ReviewActions component component snapshot: show rubric, no score 1`] =
115115
status="grading-status"
116116
/>
117117
<span
118-
className="small"
118+
className="small text-nowrap"
119119
/>
120120
</span>
121121
<div

src/containers/ReviewActions/index.jsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export const ReviewActions = ({
3030
{ gradingStatus && (
3131
<StatusBadge className="review-actions-status mr-3" status={gradingStatus} />
3232
)}
33-
<span className="small">
33+
<span className="small text-nowrap">
3434
{pointsPossible && (
3535
<FormattedMessage
3636
{...messages.pointsDisplay}
Original file line numberDiff line numberDiff line change
@@ -1,72 +1,7 @@
11
// Jest Snapshot v1, https://goo.gl/fbAQLP
22

3-
exports[`ReviewModal component component snapshots closed 1`] = `
4-
<FullscreenModal
5-
beforeBodyNode={
6-
<React.Fragment>
7-
<ReviewActions />
8-
<DemoWarning />
9-
</React.Fragment>
10-
}
11-
className="review-modal"
12-
isOpen={false}
13-
modalBodyClassName="review-modal-body"
14-
onClose={[MockFunction hooks.onClose]}
15-
title="test-ora-name"
16-
>
17-
<CloseReviewConfirmModal
18-
prop="hooks.closeConfirmModalProps"
19-
/>
20-
</FullscreenModal>
21-
`;
3+
exports[`ReviewModal component component snapshots closed 1`] = `undefined`;
224

23-
exports[`ReviewModal component component snapshots loading 1`] = `
24-
<FullscreenModal
25-
beforeBodyNode={
26-
<React.Fragment>
27-
<ReviewActions />
28-
<DemoWarning />
29-
</React.Fragment>
30-
}
31-
className="review-modal"
32-
isOpen={true}
33-
modalBodyClassName="review-modal-body"
34-
onClose={[MockFunction hooks.onClose]}
35-
title="test-ora-name"
36-
>
37-
<ReviewContent />
38-
<LoadingMessage
39-
message={
40-
Object {
41-
"defaultMessage": "Loading response",
42-
"description": "loading text for submission response review screen",
43-
"id": "ora-grading.ReviewModal.loadingResponse",
44-
}
45-
}
46-
/>
47-
<CloseReviewConfirmModal
48-
prop="hooks.closeConfirmModalProps"
49-
/>
50-
</FullscreenModal>
51-
`;
5+
exports[`ReviewModal component component snapshots loading 1`] = `undefined`;
526

53-
exports[`ReviewModal component component snapshots success 1`] = `
54-
<FullscreenModal
55-
beforeBodyNode={
56-
<React.Fragment>
57-
<ReviewActions />
58-
<DemoWarning />
59-
</React.Fragment>
60-
}
61-
className="review-modal"
62-
isOpen={true}
63-
modalBodyClassName="review-modal-body"
64-
onClose={[MockFunction hooks.onClose]}
65-
title="test-ora-name"
66-
>
67-
<ReviewContent />
68-
<CloseReviewConfirmModal
69-
prop="hooks.closeConfirmModalProps"
70-
/>
71-
</FullscreenModal>
72-
`;
7+
exports[`ReviewModal component component snapshots success 1`] = `undefined`;

src/containers/ReviewModal/index.jsx

+5-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import React from 'react';
22
import { useDispatch } from 'react-redux';
33

4-
import { FullscreenModal } from '@openedx/paragon';
4+
import { FullscreenModal, Truncate, useMediaQuery } from '@openedx/paragon';
55
import { injectIntl, intlShape } from '@edx/frontend-platform/i18n';
66

77
import LoadingMessage from 'components/LoadingMessage';
@@ -27,9 +27,12 @@ export const ReviewModal = ({ intl }) => {
2727
isOpen,
2828
closeConfirmModalProps,
2929
} = hooks.rendererHooks({ dispatch, intl });
30+
31+
const isMobile = useMediaQuery({ query: '(max-width: 575.98px)' });
32+
3033
return (
3134
<FullscreenModal
32-
title={title}
35+
title={isMobile ? <Truncate lines={3}>{title}</Truncate> : title}
3336
isOpen={isOpen}
3437
beforeBodyNode={(
3538
<>

0 commit comments

Comments
 (0)