Skip to content

Commit 4825c3d

Browse files
feat: import FooterSlot from component package instead of slot package (#414)
1 parent 4e27a35 commit 4825c3d

File tree

6 files changed

+15
-27
lines changed

6 files changed

+15
-27
lines changed

package-lock.json

+5-19
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,14 @@
2828
},
2929
"dependencies": {
3030
"@edx/brand": "npm:@openedx/brand-openedx@^1.2.2",
31-
"@edx/frontend-component-footer": "^14.3.0",
31+
"@edx/frontend-component-footer": "^14.6.0",
3232
"@edx/frontend-component-header": "^6.2.0",
3333
"@edx/frontend-platform": "^8.3.1",
3434
"@edx/openedx-atlas": "^0.6.0",
3535
"@fortawesome/fontawesome-svg-core": "^1.2.36",
3636
"@fortawesome/free-brands-svg-icons": "^5.15.4",
3737
"@fortawesome/free-solid-svg-icons": "^5.15.4",
3838
"@fortawesome/react-fontawesome": "^0.2.0",
39-
"@openedx/frontend-slot-footer": "^1.0.2",
4039
"@openedx/paragon": "^22.16.0",
4140
"@redux-beacon/segment": "^1.1.0",
4241
"@redux-devtools/extension": "3.0.0",

src/App.jsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import PropTypes from 'prop-types';
33
import { connect } from 'react-redux';
44
import { BrowserRouter as Router } from 'react-router-dom';
55

6-
import FooterSlot from '@openedx/frontend-slot-footer';
6+
import { FooterSlot } from '@edx/frontend-component-footer';
77
import { LearningHeader as Header } from '@edx/frontend-component-header';
88

99
import { selectors } from 'data/redux';

src/App.test.jsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jest.mock('data/redux', () => ({
1515
jest.mock('@edx/frontend-component-header', () => ({
1616
LearningHeader: 'Header',
1717
}));
18-
jest.mock('@edx/frontend-component-footer', () => ({ FooterSlot: 'Footer' }));
18+
jest.mock('@edx/frontend-component-footer', () => ({ FooterSlot: 'FooterSlot' }));
1919

2020
jest.mock('containers/DemoWarning', () => 'DemoWarning');
2121
jest.mock('containers/ListView', () => 'ListView');

src/plugin-slots/FooterSlot/README.md

+6-3
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,15 @@
11
# Footer Slot
22

3-
### Slot ID: `footer_slot`
3+
### Slot ID: `org.openedx.frontend.layout.footer.v1`
4+
5+
### Slot ID Aliases
6+
* `footer_slot`
47

58
## Description
69

710
This slot is used to replace/modify/hide the footer.
811

9-
The implementation of the `FooterSlot` component lives in [the `frontend-slot-footer` repository](https://github.com/openedx/frontend-slot-footer/).
12+
The implementation of the `FooterSlot` component lives in [the `frontend-component-footer` repository](https://github.com/openedx/frontend-component-footer/).
1013

1114
## Example
1215

@@ -23,7 +26,7 @@ import { DIRECT_PLUGIN, PLUGIN_OPERATIONS } from '@openedx/frontend-plugin-frame
2326

2427
const config = {
2528
pluginSlots: {
26-
footer_slot: {
29+
'org.openedx.frontend.layout.footer.v1': {
2730
plugins: [
2831
{
2932
// Hide the default footer

src/plugin-slots/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
# `frontend-app-ora-grading` Plugin Slots
22

3-
* [`footer_slot`](./FooterSlot/)
3+
* [`org.openedx.frontend.layout.footer.v1`](./FooterSlot/)

0 commit comments

Comments
 (0)