Skip to content

Commit 46cf13b

Browse files
committed
chore: remove husky 🪓🐶
We remove husky, which is triggering pre-push git hooks, including running "npm lint". This is causing failures when building Docker images, because "npm clean-install --omit=dev" automatically triggers "npm prepare", which attemps to run "husky". But husky is not listed in the build dependencies, only in devDependencies. As a consequence, package installation is failing with the following error: 14.13 > @edx/[email protected] prepare 14.13 > husky install 14.13 14.15 sh: 1: husky: not found Similar to: openedx/frontend-app-learning#1622
1 parent 5c5ff11 commit 46cf13b

File tree

3 files changed

+1
-23
lines changed

3 files changed

+1
-23
lines changed

.husky/pre-push

Lines changed: 0 additions & 4 deletions
This file was deleted.

package-lock.json

Lines changed: 0 additions & 16 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,7 @@
1818
"start": "fedx-scripts webpack-dev-server --progress",
1919
"dev": "PUBLIC_PATH=/ora-grading/ MFE_CONFIG_API_URL='http://localhost:8000/api/mfe_config/v1' fedx-scripts webpack-dev-server --progress --host apps.local.openedx.io",
2020
"test": "TZ=GMT fedx-scripts jest --coverage --passWithNoTests",
21-
"watch-tests": "jest --watch",
22-
"prepare": "husky install"
21+
"watch-tests": "jest --watch"
2322
},
2423
"author": "edX",
2524
"license": "AGPL-3.0",
@@ -85,7 +84,6 @@
8584
"@testing-library/react": "12.1.5",
8685
"axios-mock-adapter": "^1.20.0",
8786
"fetch-mock": "^9.11.0",
88-
"husky": "^7.0.0",
8987
"identity-obj-proxy": "^3.0.0",
9088
"jest": "29.7.0",
9189
"jest-environment-jsdom": "^29.7.0",

0 commit comments

Comments
 (0)