Skip to content

Problem with notes visibility feature #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #227
jfavellar90 opened this issue Nov 23, 2022 · 1 comment
Closed
Tracked by #227

Problem with notes visibility feature #1005

jfavellar90 opened this issue Nov 23, 2022 · 1 comment
Labels
bug Report of or fix for something that isn't working as intended

Comments

@jfavellar90
Copy link

jfavellar90 commented Nov 23, 2022

This issue is related to the BTR issue openedx/wg-build-test-release#227 in the context of the Nutmeg release work. The testing of the cases was performed in the BTR Olive instance.

There's a problem due to a discrepancy between the management of the notes visibility in the MFE and the Iframe serving an xblock unit content.

The notes visibility is meant to be controlled by a student preference called "edxnotes_visibility", which is stored in the table courseware_xmodulestudentinfofield. If the preference is not present for the currently logged-in user, the notes visibility is enabled by default. The unit content in a courseware page is loaded through an Iframe inside the MFE, and the preference value determines if the notes are highlighted or not when the unit is loaded.

However, the MFE notes visibility ignores the aforementioned user preference and determines the visibility based on the course metadata info extracted from a courseware API call. This API returns the values for notes in the format below:

notes:
  enabled: true
  visible: true

And this API always returns the visible field with a true value, not taking into account the "edxnotes_visibility" preference of the user. This affects the behavior of the button that toggles the notes visibility, due to the discrepancy between the notes visibility state of the unit Iframe and the MFE.

The notes visibility value in the MFE should be extracted from another source to get the value of the user preference (or make the courseware API in the LMS aware of the user calling it?).

@Agrendalath
Copy link
Member

Agrendalath commented Sep 7, 2023

Fixed in openedx/edx-platform#33096 and #1170.

@github-project-automation github-project-automation bot moved this from Backlog to Closed in Frontend Working Group Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended
Projects
Status: Closed
Development

No branches or pull requests

3 participants