Skip to content

fix: update integration warning logic to check active LMS integrations #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

ahmad-hassan-dev
Copy link
Contributor

@ahmad-hassan-dev ahmad-hassan-dev commented Mar 20, 2025

Adjust the display logic for the Integration Warning modal in the Learner Portal. Previously, the modal displayed when search was enabled and an identity provider was configured. This resulted in confusion for customers who did not have an LMS integration but saw the modal due to having SSO enabled.

Changes:

  • Update the condition to display the Integration Warning modal only if the enterprise customer has an active LMS integration.
  • Use the active_integrations field from the BFF or direct LMS API call as the new condition.
  • Ensure customers without LMS integrations do not see the modal, regardless of SSO setup.

Ticket Reference: ENT-10068 - IntegrationWarning showing for a customer with search enabled and no identity provider.

Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.68%. Comparing base (397fcbb) to head (38dc049).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1336      +/-   ##
==========================================
+ Coverage   89.64%   89.68%   +0.03%     
==========================================
  Files         405      405              
  Lines        8809     8809              
  Branches     2069     2114      +45     
==========================================
+ Hits         7897     7900       +3     
+ Misses        879      875       -4     
- Partials       33       34       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@sameeramin sameeramin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@ahmad-hassan-dev ahmad-hassan-dev merged commit 186e10b into master Mar 25, 2025
9 checks passed
@ahmad-hassan-dev ahmad-hassan-dev deleted the ahmad-hassan-dev/integration-warning branch March 25, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants