Fix/meilisearch course_team_index filterable attributes #207

zemelten · 2025-06-09T07:19:34Z

Added course_team_index filterable attributes

openedx-webhooks · 2025-06-09T07:19:38Z

Thanks for the pull request, @zemelten!

This repository is currently maintained by @Ali-Salman29.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

mphilbrick211 · 2025-06-12T02:22:49Z

Hi @zemelten - thank you for this contribution! Please let me know if you have any questions regarding submitting a CLA form. Thanks!

tecoholic

@zemelten Great work identify the right place to fix the indexes. I have requested some changes to make this PR a bit more leaner. Kindly address them.

Can you also kindly add some testing instructions to the PR description (with screenshots, if possible)?

search/meilisearch.py

tecoholic · 2025-06-12T06:13:40Z

manage.py

@@ -1,14 +1,14 @@
-#!/usr/bin/env python


We can switch this back with chmod +x manage.py I think

search/meilisearch.py

tecoholic · 2025-06-12T06:55:40Z

setup.py

@@ -1,85 +1,85 @@
-#!/usr/bin/env python


Same here. Switch this back with a chmod.

tecoholic · 2025-06-12T06:56:25Z

search/meilisearch.py

+        if(index_name == 'course_team_index'):
+            task_info = client.create_index(index_name, {"primaryKey": "id"})


We don't need this. The default PRIMARY_KEY value _pk seems to work just fine.

search/meilisearch.py

tecoholic · 2025-06-12T07:00:14Z

search/meilisearch.py

@@ -99,14 +99,32 @@
        "org",
        "catalog_visibility",  # used if not settings.SEARCH_SKIP_SHOW_IN_CATALOG_FILTERING
        "enrollment_end",  # include only enrollable courses
+        "course_id"


I don't think we need to introduce "course_id" here and in line 110. Let's not touch the other indices and just keep this fix to the course_team_index.

e0d · 2025-06-12T18:18:12Z

@zemelten
I notice there are some commit-lint failures. Please note that we use conventional commits across Open edX projects. You can read about the details here. Can you please amend your commit messages to follow our standard?

It looks like there are some other failures as well.

tecoholic · 2025-06-13T10:43:14Z

@zemelten Hi, after you address the file modes changes, I think it would best to squash all the commits into one and then use a conventions commit message as @e0d points out.

e0d · 2025-06-16T20:59:39Z

@zemelten Your branch is behind the base. I've pulled in changes from master as a merge commit which will update your branch and cause the tests to be re-run.

mphilbrick211 · 2025-06-20T20:11:47Z

Hi @zemelten! Checking in to see if this pull request is still in progress? Please let us know if you have any questions re: filling out a CLA form.

zemelten · 2025-07-01T09:00:28Z

Hi @zemelten! Checking in to see if this pull request is still in progress? Please let us know if you have any questions re: filling out a CLA form.

Hello, I have submitted the CLA form.

e0d · 2025-07-16T13:37:06Z

@zemelten It looks like there are some failing checks, please have a look.

mphilbrick211 · 2025-07-16T13:49:50Z

Hi @zemelten! Checking in to see if this pull request is still in progress? Please let us know if you have any questions re: filling out a CLA form.

Hello, I have submitted the CLA form.

@zemelten - thanks! Looks like it was sent out to you to sign 2 days ago (July 14). If you don't see it, please be sure to check your spam folder(s).

tecoholic · 2025-07-22T06:49:50Z

@zemelten Hi, can you kindly fix the tests that are failing in the CI here?

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 9, 2025

openedx-webhooks added this to Contributions Jun 9, 2025

github-project-automation bot moved this to Needs Triage in Contributions Jun 9, 2025

mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jun 12, 2025

mphilbrick211 moved this from Needs Triage to Needs Tests Run or CLA Signed in Contributions Jun 12, 2025

tecoholic suggested changes Jun 12, 2025

View reviewed changes

zemelten added a commit to zemelten/edx-search that referenced this pull request Jun 12, 2025

pr openedx#207: review comments fixed

bfa20cf

e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jun 12, 2025

zemelten added a commit to zemelten/edx-search that referenced this pull request Jun 14, 2025

pr openedx#207: review comments fixed

1ac63aa

feat: added course_team_index to Meilisearch filterable attributes

18b63f0

zemelten force-pushed the fix/meilisearch-primary-key branch from 64ca730 to 18b63f0 Compare June 16, 2025 17:07

mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jun 16, 2025

Merge branch 'master' into fix/meilisearch-primary-key

8736228

e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jun 16, 2025

mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jun 20, 2025

zemelten mentioned this pull request Jul 16, 2025

Searching for a team gives a 500 error openedx/edx-platform#36819

Open

e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jul 16, 2025

e0d moved this from Needs Tests Run or CLA Signed to Waiting on Author in Contributions Jul 16, 2025

		if(index_name == 'course_team_index'):
		task_info = client.create_index(index_name, {"primaryKey": "id"})

Fix/meilisearch course_team_index filterable attributes #207

Are you sure you want to change the base?

Fix/meilisearch course_team_index filterable attributes #207

Uh oh!

Conversation

zemelten commented Jun 9, 2025

Uh oh!

openedx-webhooks commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mphilbrick211 commented Jun 12, 2025

Uh oh!

tecoholic left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tecoholic Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tecoholic Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

tecoholic Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tecoholic Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

e0d commented Jun 12, 2025

Uh oh!

tecoholic commented Jun 13, 2025

Uh oh!

e0d commented Jun 16, 2025

Uh oh!

mphilbrick211 commented Jun 20, 2025

Uh oh!

zemelten commented Jul 1, 2025

Uh oh!

e0d commented Jul 16, 2025

Uh oh!

mphilbrick211 commented Jul 16, 2025

Uh oh!

tecoholic commented Jul 22, 2025

Uh oh!

Uh oh!

openedx-webhooks commented Jun 9, 2025 •

edited

Loading

tecoholic left a comment •

edited

Loading