-
Notifications
You must be signed in to change notification settings - Fork 4k
feat: add feature toggle for private fields in profile information report #36688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: add feature toggle for private fields in profile information report #36688
Conversation
Thanks for the pull request, @BryanttV! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
598198c
to
f166066
Compare
e235843
to
e825a39
Compare
Description
This PR introduces a new feature toggle called
SHOW_PRIVATE_FIELDS_IN_PROFILE_INFORMATION_REPORT
. This toggle allows operators to include private fields (such asyear_of_birth
) in the profile information JSON report or CSV file.Context
In this PR, the
year_of_birth
field was removed from the report containing enrolled students' profile information for a specific course.The new feature toggle gives operators the option to include or exclude private fields in these reports. By default, private fields remain hidden, preserving the current behavior. However, if an operator wants to include them, they can enable the feature toggle.
Testing instructions
Create a Tutor environment.
Create a mount of edx-platform with the changes in this PR.
Create a course and enroll some students in it.
Then, go to the LMS > [Your Course] > Instructor > Data Download > Download profile information as a CSV.
You shouldn't see the
year_of_birth
column in the CSV.Now, enable the new feature toggle in your settings. You can use this tutor inline plugin
Again, download profile information as a CSV.
You should see the
year_of_birth
column in the CSV.Deadline
None
Other information