-
Notifications
You must be signed in to change notification settings - Fork 4k
fix: expose __version__ for LXML. #36627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This changes exposes the LXML version since it is used by libraries to check LXML version. Signed-off-by: Farhaan Bukhsh <[email protected]>
Thanks for the pull request, @farhaanbukhsh! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR ensures that the LXML version is exposed for libraries that rely on it, addressing compatibility issues in downstream projects such as Parsel.
- Exposes version by updating the lxml.etree import in the safe_lxml helper module
- Resolves version checking errors in dependencies that expect the attribute
Comments suppressed due to low confidence (1)
openedx/core/lib/safe_lxml/etree.py:21
- [nitpick] Consider adding an inline comment above this import statement to explain that version is re-exported to support version checking by dependent libraries.
from lxml.etree import _Comment, _Element, _ElementTree, _Entity, _ProcessingInstruction, __version__
closing in favour of openedx/xblock-image-explorer#195 |
These changes expose the LXML version since it is used by libraries to check LXML version. We faced a problem in image-explored XBlock. Parsel needs to know the lxml version
https://github.com/scrapy/parsel/blob/master/parsel/selector.py#L35. Since this information was not being passed and etree flavor of opened.
Testing instructions:
-e ./xblock-image-explorer
in that file.tutor mounts add ./xblock-image-explorer
tutor images build openedx-dev
tutor dev start -d
tutor dev exec cms bash
./manage.py lms shell
pip install -e /mnt/xblock-image-explorer
Private Ref: Jira Ticket