-
Notifications
You must be signed in to change notification settings - Fork 4k
fix: remove dependency #36589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: remove dependency #36589
Conversation
Thanks for the pull request, @tonybusa! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
@tonybusa Your branch is behind the base. I've pulled in changes from master as a merge commit which will update your branch and cause the tests to be re-run. |
@e0d I was curious whether clicking the "Update Branch" button is sufficient to keep my branch updated with master? Or is there a preferred rebase strategy? |
Bumping this for @e0d and @brian-smith-tcril |
Is the codecov test new? This wasn't failing before, and this PR removes unwanted code, not introducing any new logic that would warrant coverage IMO. |
|
Description
This change request address the issue: openedx/public-engineering#248 by removing the reference to
karma-selenium-webdriver-launcher
in the package.json and the karma configs. Originally, I also took it a step further to comment out the tests in thelms/static/karma_lms.conf.js
that reference webpack:so that we could potentially have more code coverage if deemed useful. Otherwise, we may want to go through and delete all spec files within the LMS folder since they aren't being run, and/or maintained.
However, I think this might be better tracked in a separate ticket. Please feel free to weigh in and I can include the removal or comment of these tests.
Useful information to include:
Supporting information
Original issue: openedx/public-engineering#248
Follow up issue: #35956
Testing instructions
These affect tests that run in the CI on a linux machine. Unable to run the npm commands locally on my mac machine.
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
Include anything else that will help reviewers and consumers understand the change.