Skip to content

fix: remove dependency #36589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

tonybusa
Copy link

@tonybusa tonybusa commented Apr 23, 2025

Description

This change request address the issue: openedx/public-engineering#248 by removing the reference to karma-selenium-webdriver-launcher in the package.json and the karma configs. Originally, I also took it a step further to comment out the tests in the lms/static/karma_lms.conf.js that reference webpack:

  // Define the Webpack-built spec files first
   {pattern: 'course_experience/js/**/*_spec.js', webpack: true},
   {pattern: 'js/learner_dashboard/**/*_spec.js', webpack: true},
   {pattern: 'js/student_account/components/**/*_spec.js', webpack: true},
   {pattern: 'completion/js/**/*_spec.js', webpack: true},

so that we could potentially have more code coverage if deemed useful. Otherwise, we may want to go through and delete all spec files within the LMS folder since they aren't being run, and/or maintained.

However, I think this might be better tracked in a separate ticket. Please feel free to weigh in and I can include the removal or comment of these tests.

Useful information to include:

  • This would affect "Developer"s and would need to reinstall their node_modules.
  • If the CI passes, and we make a decision on the LMS tests, we could likely delete the commented lines in the PR, or reference the Fix and re-enable tests for legacy Webpack-built JS #35956 as a follow up to this PR.

Supporting information

Original issue: openedx/public-engineering#248
Follow up issue: #35956

Testing instructions

These affect tests that run in the CI on a linux machine. Unable to run the npm commands locally on my mac machine.

Deadline

"None" if there's no rush, or provide a specific date or event (and reason) if there is one.

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.
  • If your database migration can't be rolled back easily.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 23, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @tonybusa!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Apr 28, 2025
@e0d
Copy link
Contributor

e0d commented May 6, 2025

@tonybusa Your branch is behind the base. I've pulled in changes from master as a merge commit which will update your branch and cause the tests to be re-run.

@mphilbrick211 mphilbrick211 moved this from Ready for Review to Waiting on Author in Contributions May 6, 2025
@mphilbrick211 mphilbrick211 moved this from Waiting on Author to Ready for Review in Contributions May 6, 2025
@tonybusa
Copy link
Author

tonybusa commented May 7, 2025

@e0d I was curious whether clicking the "Update Branch" button is sufficient to keep my branch updated with master? Or is there a preferred rebase strategy?

@mphilbrick211
Copy link

Bumping this for @e0d and @brian-smith-tcril

@mphilbrick211 mphilbrick211 added the mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). label May 12, 2025
@tonybusa
Copy link
Author

Is the codecov test new? This wasn't failing before, and this PR removes unwanted code, not introducing any new logic that would warrant coverage IMO.

@mphilbrick211
Copy link

Is the codecov test new? This wasn't failing before, and this PR removes unwanted code, not introducing any new logic that would warrant coverage IMO.

@e0d @brian-smith-tcril

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). open-source-contribution PR author is not from Axim or 2U
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

4 participants