Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not have any error about runc init exit #4690

Closed
kamizjw opened this issue Mar 24, 2025 · 7 comments
Closed

do not have any error about runc init exit #4690

kamizjw opened this issue Mar 24, 2025 · 7 comments

Comments

@kamizjw
Copy link

kamizjw commented Mar 24, 2025

Image
if runc init exit when init process parent pid is changed, it do not report any error.

@rata
Copy link
Member

rata commented Mar 24, 2025

@kamizjw can you update the issue to use the template and verify your assumption?

You can comment the if and do the return unconditional. There are several runc processes, It could be that the one returning an error is no this one. I can't really see what part of the code you refer to, as that is a screenshot, and it's not clear if this issue exist.

Please see the issue template and try to provide clear information about how this issue happens

@kamizjw
Copy link
Author

kamizjw commented Mar 25, 2025

this code is in the linuxStandardInit Init function in the libcontainer/standard_init_linux.go file.
i just review code and find it, i think its parent process is generally the containerd-shim.

@kamizjw
Copy link
Author

kamizjw commented Mar 25, 2025

this code is in the linuxStandardInit Init function in the libcontainer/standard_init_linux.go file. i just review code and find it, i think its parent process is generally the containerd-shim.

but I have no idea, if it want to kill itself, how can I add relevant locatable information?

@rata
Copy link
Member

rata commented Mar 25, 2025

Please, see the issue template, update this issue to match that format, and provide code to repro this issue. As I suggested, you can patch runc to make the failure 100% reliable and see what indeed happens in that case.

Without that, you are asking us to invest time to see if the issue you have in mind is indeed an issue.

It is much more useful if you can do that exercise yourself (verify if what you think reading the code is an issue, is really an issue) and let us know of the real issues you find. We are trying our best, we have limited time, and ideas to investigate if there could be an issue, while interesting and worth pursuing, are not in the top priority. We will get to it, just later. We will fix real issues before, unless this sounds super serious or security sensitive (it doesn't in this case).

@kamizjw
Copy link
Author

kamizjw commented Mar 25, 2025

i try that,it looks like this

[root@localhost test]# runc run mycontainer
libcontainer: container init failed to execERRO[0000] runc run failed: container process is already dead

there is no other specific error information.

@rata
Copy link
Member

rata commented Mar 25, 2025

@kamizjw Have you read my last message? Please read my messages and follow what I said to provide an issue we can act on

@kamizjw
Copy link
Author

kamizjw commented Mar 26, 2025

@kamizjw Have you read my last message? Please read my messages and follow what I said to provide an issue we can act on

ok,i new a issue:#4699

@kamizjw kamizjw closed this as completed Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants