Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Which runc version should we set in the /VERSION file on the main branch? #4681

Open
rata opened this issue Mar 14, 2025 · 5 comments
Open

Comments

@rata
Copy link
Member

rata commented Mar 14, 2025

Now we have:

  • main: VERSION 1.3.0-rc.1+dev
  • release-1.3: VERSION 1.3.0-rc.1 (even after the tag)

Shall release-1.3 have 1.3.0-rc.1+dev? In which case main might be 1.4.<something>?

What do others think?

@AkihiroSuda
Copy link
Member

The version should be dynamically set from ReadBuildInfo()

https://github.com/containerd/nerdctl/blob/v2.0.3/pkg/version/version.go

@rata
Copy link
Member Author

rata commented Mar 18, 2025

@AkihiroSuda that is the go version, right? No, sorry, I meant the runc version we put in the VERSION file

@rata rata changed the title [RFC] Which VERSION should we use on main? [RFC] Which runc version should we set in the /VERSION file on the main branch? Mar 18, 2025
@AkihiroSuda
Copy link
Member

that is the go version

No, the version of the runc module

@rata
Copy link
Member Author

rata commented Mar 19, 2025

@AkihiroSuda not sure I follow. When someone runs runc -v in a runc compiled from main now, what should the runc version be?

@AkihiroSuda
Copy link
Member

@AkihiroSuda not sure I follow. When someone runs runc -v in a runc compiled from main now, what should the runc version be?

Should be the value of the vcs.revision (i.e., the git commit hash)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants