Skip to content

Commit e63cec2

Browse files
committed
Switch to github.com/moby/sys/capability v0.2.0
This removes the last unversioned package in runc's direct dependencies. Signed-off-by: Kir Kolyshkin <[email protected]>
1 parent 4546b8b commit e63cec2

File tree

16 files changed

+242
-246
lines changed

16 files changed

+242
-246
lines changed

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,14 @@ require (
1010
github.com/cyphar/filepath-securejoin v0.3.2
1111
github.com/docker/go-units v0.5.0
1212
github.com/godbus/dbus/v5 v5.1.0
13+
github.com/moby/sys/capability v0.2.0
1314
github.com/moby/sys/mountinfo v0.7.1
1415
github.com/moby/sys/user v0.1.0
1516
github.com/mrunalp/fileutils v0.5.1
1617
github.com/opencontainers/runtime-spec v1.2.0
1718
github.com/opencontainers/selinux v1.11.0
1819
github.com/seccomp/libseccomp-golang v0.10.0
1920
github.com/sirupsen/logrus v1.9.3
20-
github.com/syndtr/gocapability v0.0.0-20200815063812-42c35b437635
2121
github.com/urfave/cli v1.22.14
2222
github.com/vishvananda/netlink v1.1.0
2323
golang.org/x/net v0.24.0

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@ github.com/mdlayher/netlink v1.7.2 h1:/UtM3ofJap7Vl4QWCPDGXY8d3GIY2UGSDbK+QWmY8/
3838
github.com/mdlayher/netlink v1.7.2/go.mod h1:xraEF7uJbxLhc5fpHL4cPe221LI2bdttWlU+ZGLfQSw=
3939
github.com/mdlayher/socket v0.4.1 h1:eM9y2/jlbs1M615oshPQOHZzj6R6wMT7bX5NPiQvn2U=
4040
github.com/mdlayher/socket v0.4.1/go.mod h1:cAqeGjoufqdxWkD7DkpyS+wcefOtmu5OQ8KuoJGIReA=
41+
github.com/moby/sys/capability v0.2.0 h1:OJtbqfthavtfh1kycvEhMvY7/M2BHscP2fiXgzKI3sk=
42+
github.com/moby/sys/capability v0.2.0/go.mod h1:4g9IK291rVkms3LKCDOoYlnV8xKwoDTpIrNEE35Wq0I=
4143
github.com/moby/sys/mountinfo v0.7.1 h1:/tTvQaSJRr2FshkhXiIpux6fQ2Zvc4j7tAhMTStAG2g=
4244
github.com/moby/sys/mountinfo v0.7.1/go.mod h1:IJb6JQeOklcdMU9F5xQ8ZALD+CUr5VlGpwtX+VE0rpI=
4345
github.com/moby/sys/user v0.1.0 h1:WmZ93f5Ux6het5iituh9x2zAG7NFY9Aqi49jjE1PaQg=
@@ -69,8 +71,6 @@ github.com/stretchr/testify v1.8.0/go.mod h1:yNjHg4UonilssWZ8iaSj1OCr/vHnekPRkoO
6971
github.com/stretchr/testify v1.8.4/go.mod h1:sz/lmYIOXD/1dqDmKjjqLyZ2RngseejIcXlSw2iwfAo=
7072
github.com/stretchr/testify v1.9.0 h1:HtqpIVDClZ4nwg75+f6Lvsy/wHu+3BoSGCbBAcpTsTg=
7173
github.com/stretchr/testify v1.9.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY=
72-
github.com/syndtr/gocapability v0.0.0-20200815063812-42c35b437635 h1:kdXcSzyDtseVEc4yCz2qF8ZrQvIDBJLl4S1c3GCXmoI=
73-
github.com/syndtr/gocapability v0.0.0-20200815063812-42c35b437635/go.mod h1:hkRG7XYTFWNJGYcbNJQlaLq0fg1yr4J4t/NcTQtrfww=
7474
github.com/urfave/cli v1.22.14 h1:ebbhrRiGK2i4naQJr+1Xj92HXZCrK7MsyTS/ob3HnAk=
7575
github.com/urfave/cli v1.22.14/go.mod h1:X0eDS6pD6Exaclxm99NJ3FiCDRED7vIHpx2mDOHLvkA=
7676
github.com/vishvananda/netlink v1.1.0 h1:1iyaYNBLmP6L0220aDnYQpo1QEV4t4hJ+xEEhhJH8j0=

libcontainer/capabilities/capabilities.go

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ import (
88
"strings"
99
"sync"
1010

11+
"github.com/moby/sys/capability"
1112
"github.com/opencontainers/runc/libcontainer/configs"
1213
"github.com/sirupsen/logrus"
13-
"github.com/syndtr/gocapability/capability"
1414
)
1515

1616
const allCapabilityTypes = capability.CAPS | capability.BOUNDING | capability.AMBIENT
@@ -24,15 +24,19 @@ var (
2424
capability.AMBIENT,
2525
}
2626

27-
capMap = sync.OnceValue(func() map[string]capability.Cap {
28-
cm := make(map[string]capability.Cap, capability.CAP_LAST_CAP+1)
27+
capMap = sync.OnceValues(func() (map[string]capability.Cap, error) {
28+
last, err := capability.LastCap()
29+
if err != nil {
30+
return nil, err
31+
}
32+
cm := make(map[string]capability.Cap, last+1)
2933
for _, c := range capability.List() {
30-
if c > capability.CAP_LAST_CAP {
34+
if c > last {
3135
continue
3236
}
3337
cm["CAP_"+strings.ToUpper(c.String())] = c
3438
}
35-
return cm
39+
return cm, nil
3640
})
3741
)
3842

@@ -51,12 +55,12 @@ func KnownCapabilities() []string {
5155
// or Capabilities that are unavailable in the current environment are ignored,
5256
// printing a warning instead.
5357
func New(capConfig *configs.Capabilities) (*Caps, error) {
54-
var (
55-
err error
56-
c Caps
57-
)
58+
var c Caps
5859

59-
cm := capMap()
60+
cm, err := capMap()
61+
if err != nil {
62+
return nil, err
63+
}
6064
unknownCaps := make(map[string]struct{})
6165
ignoredCaps := make(map[string]struct{})
6266
// capSlice converts the slice of capability names in caps, to their numeric

libcontainer/capabilities/capabilities_linux_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,10 @@ import (
55
"os"
66
"testing"
77

8+
"github.com/moby/sys/capability"
89
"github.com/opencontainers/runc/libcontainer/configs"
910
"github.com/sirupsen/logrus"
1011
"github.com/sirupsen/logrus/hooks/test"
11-
"github.com/syndtr/gocapability/capability"
1212
)
1313

1414
func TestNew(t *testing.T) {

vendor/github.com/moby/sys/capability/.codespellrc

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/moby/sys/capability/.golangci.yml

Lines changed: 6 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/moby/sys/capability/CHANGELOG.md

Lines changed: 72 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/syndtr/gocapability/LICENSE renamed to vendor/github.com/moby/sys/capability/LICENSE

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/moby/sys/capability/README.md

Lines changed: 11 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/syndtr/gocapability/capability/capability.go renamed to vendor/github.com/moby/sys/capability/capability.go

Lines changed: 28 additions & 27 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)