Skip to content

Commit 346b818

Browse files
authored
Merge pull request #4380 from rata/makefile-no-envs
Makefile: Don't read COMMIT, BUILDTAGS, EXTRA_BUILDTAGS from env vars
2 parents a41b62a + 767bc00 commit 346b818

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

Makefile

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,11 @@ GIT_BRANCH := $(shell git rev-parse --abbrev-ref HEAD 2>/dev/null)
1414
GIT_BRANCH_CLEAN := $(shell echo $(GIT_BRANCH) | sed -e "s/[^[:alnum:]]/-/g")
1515
RUNC_IMAGE := runc_dev$(if $(GIT_BRANCH_CLEAN),:$(GIT_BRANCH_CLEAN))
1616
PROJECT := github.com/opencontainers/runc
17-
BUILDTAGS ?= seccomp urfave_cli_no_docs
17+
EXTRA_BUILDTAGS :=
18+
BUILDTAGS := seccomp urfave_cli_no_docs
1819
BUILDTAGS += $(EXTRA_BUILDTAGS)
1920

20-
COMMIT ?= $(shell git describe --dirty --long --always)
21+
COMMIT := $(shell git describe --dirty --long --always)
2122
EXTRA_VERSION :=
2223
VERSION := $(shell cat ./VERSION)$(EXTRA_VERSION)
2324
LDFLAGS_COMMON := -X main.gitCommit=$(COMMIT) -X main.version=$(VERSION)

0 commit comments

Comments
 (0)