devices: rm nolint annotations

Both revive and staticcheck complains like this:

> devices/devices_emulator.go:239:20: ST1016: methods on the same type should have the same receiver name (seen 1x "source", 8x "e") (staticcheck)
> func (e *emulator) Apply(rule devices.Rule) error {
>                    ^

What they mean to point to is this line:

> func (source *emulator) Transition(target *emulator) ([]*devices.Rule, error) {

In here, "source" does actually make sense, but instead of suppressing
these warnings, let's just give up and rename the receiver, and
introduce a source variable instead.

Signed-off-by: Kir Kolyshkin <[email protected]>

Author: kolyshkin

devices/devices_emulator.go

@@ -304,8 +304,9 @@ func emulatorFromList(list io.Reader) (*emulator, error) {
 // This function is the sole reason for all of emulator -- to allow us
 // to figure out how to update a containers' cgroups without causing spurious
 // device errors (if possible).
-func (source *emulator) Transition(target *emulator) ([]*devices.Rule, error) { //nolint:revive // Ignore receiver-naming warning.
+func (e *emulator) Transition(target *emulator) ([]*devices.Rule, error) {
 	var transitionRules []*devices.Rule
+	source := e
 	oldRules := source.rules
 
 	// If the default policy doesn't match, we need to include a "disruptive"