Launch mcp at application startup

Author: jankrepl

backend/src/neuroagent/app/main.py

@@ -23,6 +23,7 @@
 from starlette.responses import JSONResponse
 
 from neuroagent import __version__
+from neuroagent.mcp import MCPClient
 from neuroagent.app.app_utils import get_semantic_router, setup_engine
 from neuroagent.app.config import Settings
 from neuroagent.app.dependencies import (
@@ -113,6 +114,14 @@ async def lifespan(fastapi_app: FastAPI) -> AsyncContextManager[None]:  # type:
     semantic_router = get_semantic_router(settings=app_settings)
     app.state.semantic_router = semantic_router
 
+    if app_settings.mcp.config_path is not None:
+        mcp_client: MCPClient | None = MCPClient(
+            config_path=app_settings.mcp.config_path,
+        )
+        await mcp_client.connect_to_servers()
+    else:
+        mcp_client = None
+
     async with aclosing(
         AsyncAccountingSessionFactory(
             base_url=app_settings.accounting.base_url,
@@ -130,6 +139,9 @@ async def lifespan(fastapi_app: FastAPI) -> AsyncContextManager[None]:  # type:
     if fastapi_app.state.redis_client is not None:
         await fastapi_app.state.redis_client.aclose()
 
+    if mcp_client is not None:
+        await mcp_client.cleanup()
+
 
 app = FastAPI(
     title="Agents",

backend/src/neuroagent/mcp.py

@@ -2,13 +2,16 @@
 
 import asyncio
 import json
+import logging
 from contextlib import AsyncExitStack
 from pathlib import Path
 
 from mcp import ClientSession, StdioServerParameters
 from mcp.client.stdio import stdio_client
 from pydantic import BaseModel
 
+logger = logging.getLogger(__name__)
+
 
 class MCPServerConfig(BaseModel):
     command: str
@@ -45,7 +48,7 @@ async def connect_to_servers(self) -> None:
             server_script_path: Path to the server script (.py or .js)
         """
         for name, server_config in self.config.servers.items():
-            print(f"Connecting to server: {name}")
+            logger.info(f"Connecting to server: {name}")
             server_params = StdioServerParameters(
                 command=server_config.command,
                 args=server_config.args or [],
@@ -64,15 +67,15 @@ async def connect_to_servers(self) -> None:
             # List available tools
             response = await self.sessions[name].list_tools()
             tools = response.tools
-            print("\nConnected to server with tools:", [tool.name for tool in tools])
 
-    async def cleanup(self):
+    async def cleanup(self) -> None:
         """Clean up resources"""
-        # await self.exit_stack.aclose()
 
-        for name, stack in self.exit_stack.items():
-            print(f"Cleaning up server: {name}")
-            await stack.aclose()
+        # Unfortunately, the below code seems to have an issue
+
+        # for name, stack in self.exit_stack.items():
+        #     logger.info(f"Cleaning up server: {name}")
+        #     await stack.aclose()
 
 
 async def main():