Skip to content

Two bugs during extraction of sub-circuits #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MWolfR opened this issue May 16, 2025 · 0 comments
Open

Two bugs during extraction of sub-circuits #3

MWolfR opened this issue May 16, 2025 · 0 comments

Comments

@MWolfR
Copy link

MWolfR commented May 16, 2025

Affects: brainbuilder.utils.sonata.split_population.split_subcircuit.

  1. When extracting a subcircuit with the “do_virtual” option active, no filtering is applied to the virtual populations that are propagated to the extracted circuit. Currently, if one extracts e.g., “Layer4Inhbitory” from a circuit, then virtual populations with “layer” and “synapse_class” properties are filtered as well. That should not be the case.

  2. When extracting a subcircuit with the “create_external” option active, the newly created extrinsic edge file should reference the correct presynaptic node population. Currently, it references the name of the node population in the parent circuit, but it should be the new name of the node population, e.g., with “external_” prepended. The entry in question is in the dataset attributes of the sonata edge file at: "edges/$POP_NAME/source_node_id". The property in question is "node_population"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant