Skip to content

Commit 9a25149

Browse files
fix(client): ensure path params are non-empty (#1075)
1 parent 0e93c3b commit 9a25149

File tree

23 files changed

+870
-10
lines changed

23 files changed

+870
-10
lines changed

src/openai/resources/audio/transcriptions.py

-2
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@ def create(
9898
# sent to the server will contain a `boundary` parameter, e.g.
9999
# multipart/form-data; boundary=---abc--
100100
extra_headers = {"Content-Type": "multipart/form-data", **(extra_headers or {})}
101-
102101
return self._post(
103102
"/audio/transcriptions",
104103
body=maybe_transform(body, transcription_create_params.TranscriptionCreateParams),
@@ -187,7 +186,6 @@ async def create(
187186
# sent to the server will contain a `boundary` parameter, e.g.
188187
# multipart/form-data; boundary=---abc--
189188
extra_headers = {"Content-Type": "multipart/form-data", **(extra_headers or {})}
190-
191189
return await self._post(
192190
"/audio/transcriptions",
193191
body=maybe_transform(body, transcription_create_params.TranscriptionCreateParams),

src/openai/resources/audio/translations.py

-2
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,6 @@ def create(
9191
# sent to the server will contain a `boundary` parameter, e.g.
9292
# multipart/form-data; boundary=---abc--
9393
extra_headers = {"Content-Type": "multipart/form-data", **(extra_headers or {})}
94-
9594
return self._post(
9695
"/audio/translations",
9796
body=maybe_transform(body, translation_create_params.TranslationCreateParams),
@@ -173,7 +172,6 @@ async def create(
173172
# sent to the server will contain a `boundary` parameter, e.g.
174173
# multipart/form-data; boundary=---abc--
175174
extra_headers = {"Content-Type": "multipart/form-data", **(extra_headers or {})}
176-
177175
return await self._post(
178176
"/audio/translations",
179177
body=maybe_transform(body, translation_create_params.TranslationCreateParams),

src/openai/resources/beta/assistants/assistants.py

+12
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,8 @@ def retrieve(
148148
149149
timeout: Override the client-level default timeout for this request, in seconds
150150
"""
151+
if not assistant_id:
152+
raise ValueError(f"Expected a non-empty value for `assistant_id` but received {assistant_id!r}")
151153
extra_headers = {"OpenAI-Beta": "assistants=v1", **(extra_headers or {})}
152154
return self._get(
153155
f"/assistants/{assistant_id}",
@@ -215,6 +217,8 @@ def update(
215217
216218
timeout: Override the client-level default timeout for this request, in seconds
217219
"""
220+
if not assistant_id:
221+
raise ValueError(f"Expected a non-empty value for `assistant_id` but received {assistant_id!r}")
218222
extra_headers = {"OpenAI-Beta": "assistants=v1", **(extra_headers or {})}
219223
return self._post(
220224
f"/assistants/{assistant_id}",
@@ -324,6 +328,8 @@ def delete(
324328
325329
timeout: Override the client-level default timeout for this request, in seconds
326330
"""
331+
if not assistant_id:
332+
raise ValueError(f"Expected a non-empty value for `assistant_id` but received {assistant_id!r}")
327333
extra_headers = {"OpenAI-Beta": "assistants=v1", **(extra_headers or {})}
328334
return self._delete(
329335
f"/assistants/{assistant_id}",
@@ -445,6 +451,8 @@ async def retrieve(
445451
446452
timeout: Override the client-level default timeout for this request, in seconds
447453
"""
454+
if not assistant_id:
455+
raise ValueError(f"Expected a non-empty value for `assistant_id` but received {assistant_id!r}")
448456
extra_headers = {"OpenAI-Beta": "assistants=v1", **(extra_headers or {})}
449457
return await self._get(
450458
f"/assistants/{assistant_id}",
@@ -512,6 +520,8 @@ async def update(
512520
513521
timeout: Override the client-level default timeout for this request, in seconds
514522
"""
523+
if not assistant_id:
524+
raise ValueError(f"Expected a non-empty value for `assistant_id` but received {assistant_id!r}")
515525
extra_headers = {"OpenAI-Beta": "assistants=v1", **(extra_headers or {})}
516526
return await self._post(
517527
f"/assistants/{assistant_id}",
@@ -621,6 +631,8 @@ async def delete(
621631
622632
timeout: Override the client-level default timeout for this request, in seconds
623633
"""
634+
if not assistant_id:
635+
raise ValueError(f"Expected a non-empty value for `assistant_id` but received {assistant_id!r}")
624636
extra_headers = {"OpenAI-Beta": "assistants=v1", **(extra_headers or {})}
625637
return await self._delete(
626638
f"/assistants/{assistant_id}",

src/openai/resources/beta/assistants/files.py

+24
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,8 @@ def create(
6161
6262
timeout: Override the client-level default timeout for this request, in seconds
6363
"""
64+
if not assistant_id:
65+
raise ValueError(f"Expected a non-empty value for `assistant_id` but received {assistant_id!r}")
6466
extra_headers = {"OpenAI-Beta": "assistants=v1", **(extra_headers or {})}
6567
return self._post(
6668
f"/assistants/{assistant_id}/files",
@@ -95,6 +97,10 @@ def retrieve(
9597
9698
timeout: Override the client-level default timeout for this request, in seconds
9799
"""
100+
if not assistant_id:
101+
raise ValueError(f"Expected a non-empty value for `assistant_id` but received {assistant_id!r}")
102+
if not file_id:
103+
raise ValueError(f"Expected a non-empty value for `file_id` but received {file_id!r}")
98104
extra_headers = {"OpenAI-Beta": "assistants=v1", **(extra_headers or {})}
99105
return self._get(
100106
f"/assistants/{assistant_id}/files/{file_id}",
@@ -147,6 +153,8 @@ def list(
147153
148154
timeout: Override the client-level default timeout for this request, in seconds
149155
"""
156+
if not assistant_id:
157+
raise ValueError(f"Expected a non-empty value for `assistant_id` but received {assistant_id!r}")
150158
extra_headers = {"OpenAI-Beta": "assistants=v1", **(extra_headers or {})}
151159
return self._get_api_list(
152160
f"/assistants/{assistant_id}/files",
@@ -193,6 +201,10 @@ def delete(
193201
194202
timeout: Override the client-level default timeout for this request, in seconds
195203
"""
204+
if not assistant_id:
205+
raise ValueError(f"Expected a non-empty value for `assistant_id` but received {assistant_id!r}")
206+
if not file_id:
207+
raise ValueError(f"Expected a non-empty value for `file_id` but received {file_id!r}")
196208
extra_headers = {"OpenAI-Beta": "assistants=v1", **(extra_headers or {})}
197209
return self._delete(
198210
f"/assistants/{assistant_id}/files/{file_id}",
@@ -242,6 +254,8 @@ async def create(
242254
243255
timeout: Override the client-level default timeout for this request, in seconds
244256
"""
257+
if not assistant_id:
258+
raise ValueError(f"Expected a non-empty value for `assistant_id` but received {assistant_id!r}")
245259
extra_headers = {"OpenAI-Beta": "assistants=v1", **(extra_headers or {})}
246260
return await self._post(
247261
f"/assistants/{assistant_id}/files",
@@ -276,6 +290,10 @@ async def retrieve(
276290
277291
timeout: Override the client-level default timeout for this request, in seconds
278292
"""
293+
if not assistant_id:
294+
raise ValueError(f"Expected a non-empty value for `assistant_id` but received {assistant_id!r}")
295+
if not file_id:
296+
raise ValueError(f"Expected a non-empty value for `file_id` but received {file_id!r}")
279297
extra_headers = {"OpenAI-Beta": "assistants=v1", **(extra_headers or {})}
280298
return await self._get(
281299
f"/assistants/{assistant_id}/files/{file_id}",
@@ -328,6 +346,8 @@ def list(
328346
329347
timeout: Override the client-level default timeout for this request, in seconds
330348
"""
349+
if not assistant_id:
350+
raise ValueError(f"Expected a non-empty value for `assistant_id` but received {assistant_id!r}")
331351
extra_headers = {"OpenAI-Beta": "assistants=v1", **(extra_headers or {})}
332352
return self._get_api_list(
333353
f"/assistants/{assistant_id}/files",
@@ -374,6 +394,10 @@ async def delete(
374394
375395
timeout: Override the client-level default timeout for this request, in seconds
376396
"""
397+
if not assistant_id:
398+
raise ValueError(f"Expected a non-empty value for `assistant_id` but received {assistant_id!r}")
399+
if not file_id:
400+
raise ValueError(f"Expected a non-empty value for `file_id` but received {file_id!r}")
377401
extra_headers = {"OpenAI-Beta": "assistants=v1", **(extra_headers or {})}
378402
return await self._delete(
379403
f"/assistants/{assistant_id}/files/{file_id}",

src/openai/resources/beta/threads/messages/files.py

+20
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,12 @@ def retrieve(
5656
5757
timeout: Override the client-level default timeout for this request, in seconds
5858
"""
59+
if not thread_id:
60+
raise ValueError(f"Expected a non-empty value for `thread_id` but received {thread_id!r}")
61+
if not message_id:
62+
raise ValueError(f"Expected a non-empty value for `message_id` but received {message_id!r}")
63+
if not file_id:
64+
raise ValueError(f"Expected a non-empty value for `file_id` but received {file_id!r}")
5965
extra_headers = {"OpenAI-Beta": "assistants=v1", **(extra_headers or {})}
6066
return self._get(
6167
f"/threads/{thread_id}/messages/{message_id}/files/{file_id}",
@@ -110,6 +116,10 @@ def list(
110116
111117
timeout: Override the client-level default timeout for this request, in seconds
112118
"""
119+
if not thread_id:
120+
raise ValueError(f"Expected a non-empty value for `thread_id` but received {thread_id!r}")
121+
if not message_id:
122+
raise ValueError(f"Expected a non-empty value for `message_id` but received {message_id!r}")
113123
extra_headers = {"OpenAI-Beta": "assistants=v1", **(extra_headers or {})}
114124
return self._get_api_list(
115125
f"/threads/{thread_id}/messages/{message_id}/files",
@@ -167,6 +177,12 @@ async def retrieve(
167177
168178
timeout: Override the client-level default timeout for this request, in seconds
169179
"""
180+
if not thread_id:
181+
raise ValueError(f"Expected a non-empty value for `thread_id` but received {thread_id!r}")
182+
if not message_id:
183+
raise ValueError(f"Expected a non-empty value for `message_id` but received {message_id!r}")
184+
if not file_id:
185+
raise ValueError(f"Expected a non-empty value for `file_id` but received {file_id!r}")
170186
extra_headers = {"OpenAI-Beta": "assistants=v1", **(extra_headers or {})}
171187
return await self._get(
172188
f"/threads/{thread_id}/messages/{message_id}/files/{file_id}",
@@ -221,6 +237,10 @@ def list(
221237
222238
timeout: Override the client-level default timeout for this request, in seconds
223239
"""
240+
if not thread_id:
241+
raise ValueError(f"Expected a non-empty value for `thread_id` but received {thread_id!r}")
242+
if not message_id:
243+
raise ValueError(f"Expected a non-empty value for `message_id` but received {message_id!r}")
224244
extra_headers = {"OpenAI-Beta": "assistants=v1", **(extra_headers or {})}
225245
return self._get_api_list(
226246
f"/threads/{thread_id}/messages/{message_id}/files",

src/openai/resources/beta/threads/messages/messages.py

+24
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,8 @@ def create(
8686
8787
timeout: Override the client-level default timeout for this request, in seconds
8888
"""
89+
if not thread_id:
90+
raise ValueError(f"Expected a non-empty value for `thread_id` but received {thread_id!r}")
8991
extra_headers = {"OpenAI-Beta": "assistants=v1", **(extra_headers or {})}
9092
return self._post(
9193
f"/threads/{thread_id}/messages",
@@ -128,6 +130,10 @@ def retrieve(
128130
129131
timeout: Override the client-level default timeout for this request, in seconds
130132
"""
133+
if not thread_id:
134+
raise ValueError(f"Expected a non-empty value for `thread_id` but received {thread_id!r}")
135+
if not message_id:
136+
raise ValueError(f"Expected a non-empty value for `message_id` but received {message_id!r}")
131137
extra_headers = {"OpenAI-Beta": "assistants=v1", **(extra_headers or {})}
132138
return self._get(
133139
f"/threads/{thread_id}/messages/{message_id}",
@@ -167,6 +173,10 @@ def update(
167173
168174
timeout: Override the client-level default timeout for this request, in seconds
169175
"""
176+
if not thread_id:
177+
raise ValueError(f"Expected a non-empty value for `thread_id` but received {thread_id!r}")
178+
if not message_id:
179+
raise ValueError(f"Expected a non-empty value for `message_id` but received {message_id!r}")
170180
extra_headers = {"OpenAI-Beta": "assistants=v1", **(extra_headers or {})}
171181
return self._post(
172182
f"/threads/{thread_id}/messages/{message_id}",
@@ -220,6 +230,8 @@ def list(
220230
221231
timeout: Override the client-level default timeout for this request, in seconds
222232
"""
233+
if not thread_id:
234+
raise ValueError(f"Expected a non-empty value for `thread_id` but received {thread_id!r}")
223235
extra_headers = {"OpenAI-Beta": "assistants=v1", **(extra_headers or {})}
224236
return self._get_api_list(
225237
f"/threads/{thread_id}/messages",
@@ -298,6 +310,8 @@ async def create(
298310
299311
timeout: Override the client-level default timeout for this request, in seconds
300312
"""
313+
if not thread_id:
314+
raise ValueError(f"Expected a non-empty value for `thread_id` but received {thread_id!r}")
301315
extra_headers = {"OpenAI-Beta": "assistants=v1", **(extra_headers or {})}
302316
return await self._post(
303317
f"/threads/{thread_id}/messages",
@@ -340,6 +354,10 @@ async def retrieve(
340354
341355
timeout: Override the client-level default timeout for this request, in seconds
342356
"""
357+
if not thread_id:
358+
raise ValueError(f"Expected a non-empty value for `thread_id` but received {thread_id!r}")
359+
if not message_id:
360+
raise ValueError(f"Expected a non-empty value for `message_id` but received {message_id!r}")
343361
extra_headers = {"OpenAI-Beta": "assistants=v1", **(extra_headers or {})}
344362
return await self._get(
345363
f"/threads/{thread_id}/messages/{message_id}",
@@ -379,6 +397,10 @@ async def update(
379397
380398
timeout: Override the client-level default timeout for this request, in seconds
381399
"""
400+
if not thread_id:
401+
raise ValueError(f"Expected a non-empty value for `thread_id` but received {thread_id!r}")
402+
if not message_id:
403+
raise ValueError(f"Expected a non-empty value for `message_id` but received {message_id!r}")
382404
extra_headers = {"OpenAI-Beta": "assistants=v1", **(extra_headers or {})}
383405
return await self._post(
384406
f"/threads/{thread_id}/messages/{message_id}",
@@ -432,6 +454,8 @@ def list(
432454
433455
timeout: Override the client-level default timeout for this request, in seconds
434456
"""
457+
if not thread_id:
458+
raise ValueError(f"Expected a non-empty value for `thread_id` but received {thread_id!r}")
435459
extra_headers = {"OpenAI-Beta": "assistants=v1", **(extra_headers or {})}
436460
return self._get_api_list(
437461
f"/threads/{thread_id}/messages",

0 commit comments

Comments
 (0)