Skip to content

Support Github notifications for at least 3 chains #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
karolk91 opened this issue Apr 7, 2025 · 3 comments
Open

Support Github notifications for at least 3 chains #228

karolk91 opened this issue Apr 7, 2025 · 3 comments

Comments

@karolk91
Copy link
Contributor

karolk91 commented Apr 7, 2025

Currently, when test is a failure there will be a comment created within Github issue as means to notify potentially interested Github users of such event (consider example here #141 (comment))

Current mechanism works for up to 2 networks, based on naming pattern of a file that has the failing test case inside (eg. chain1.chain2.test.ts). The name like chain1 is checked against notifications.json to find the ID of github issue that the chain1 in this example is corresponding to

This issue is to extend the support for more than 2 chains, considering at least 3 to cover cases where 3 chains interact with each other as following PR #218 introduced such scenarios

@xlc
Copy link
Member

xlc commented Apr 7, 2025

I am thinking maybe we can find a better way to indicate relevant networks other than file names? e.g. have the test files to have a export const networks = ['polkadot', 'acala'] so that we don't have to force a naming pattern to the test files?

@karolk91
Copy link
Contributor Author

karolk91 commented Apr 8, 2025

I am thinking maybe we can find a better way to indicate relevant networks other than file names? e.g. have the test files to have a export const networks = ['polkadot', 'acala'] so that we don't have to force a naming pattern to the test files?

this is great idea, I can explore this and propose some PR

@rockbmb
Copy link
Collaborator

rockbmb commented Apr 8, 2025

This is a good idea - as the number of networks, chains, and tests, as well as the kind of tests (e.g. E2E, XCM) grows, some additional level of organization will be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants