You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, when test is a failure there will be a comment created within Github issue as means to notify potentially interested Github users of such event (consider example here #141 (comment))
Current mechanism works for up to 2 networks, based on naming pattern of a file that has the failing test case inside (eg. chain1.chain2.test.ts). The name like chain1 is checked against notifications.json to find the ID of github issue that the chain1 in this example is corresponding to
This issue is to extend the support for more than 2 chains, considering at least 3 to cover cases where 3 chains interact with each other as following PR #218 introduced such scenarios
The text was updated successfully, but these errors were encountered:
I am thinking maybe we can find a better way to indicate relevant networks other than file names? e.g. have the test files to have a export const networks = ['polkadot', 'acala'] so that we don't have to force a naming pattern to the test files?
I am thinking maybe we can find a better way to indicate relevant networks other than file names? e.g. have the test files to have a export const networks = ['polkadot', 'acala'] so that we don't have to force a naming pattern to the test files?
this is great idea, I can explore this and propose some PR
This is a good idea - as the number of networks, chains, and tests, as well as the kind of tests (e.g. E2E, XCM) grows, some additional level of organization will be helpful.
Currently, when test is a failure there will be a comment created within Github issue as means to notify potentially interested Github users of such event (consider example here #141 (comment))
Current mechanism works for up to 2 networks, based on naming pattern of a file that has the failing test case inside (eg.
chain1.chain2.test.ts
). The name likechain1
is checked against notifications.json to find the ID of github issue that thechain1
in this example is corresponding toThis issue is to extend the support for more than 2 chains, considering at least 3 to cover cases where 3 chains interact with each other as following PR #218 introduced such scenarios
The text was updated successfully, but these errors were encountered: