Skip to content

[i18n] Localize "page not translated" banner #6288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
4 of 7 tasks
chalin opened this issue Feb 11, 2025 · 10 comments
Open
4 of 7 tasks

[i18n] Localize "page not translated" banner #6288

chalin opened this issue Feb 11, 2025 · 10 comments
Assignees
Labels
enhancement New feature or request i18n Internationalization and localization

Comments

@chalin
Copy link
Contributor

chalin commented Feb 11, 2025

This is a followup to #6287. The goal will be to display the banner text in the appropriate local.

Tasks

@chalin chalin added enhancement New feature or request i18n Internationalization and localization labels Feb 11, 2025
@chalin chalin self-assigned this Feb 11, 2025
@vitorvasc
Copy link
Member

I'm working on this for pt but I can't see it working on the deploy preview.

Where should we put the file? Tried some alternatives, none of them worked:

  • /layouts/pt/docs/td-content-after-header.html
  • /layouts/docs/pt/td-content-after-header.html
  • /layouts/docs/pt/docs/td-content-after-header.html

@chalin
Copy link
Contributor Author

chalin commented Feb 12, 2025

Thanks @vitorvasc. I haven't decided how to setup the locale-specific banner messages yet. So for now, just providing the updated text would be great! 🙌🏻

@iguitton
Copy link
Contributor

@chalin , here are the texts for the French and Spanish versions:

  • fr: Vous consultez la traduction automatique de la version anglaise car cette page n'a pas encore été traduite dans votre langue par notre équipe. Vous souhaitez apporter votre aide ? Consultez la page "Contribuer".
  • es : Estás viendo la traducción automática de la versión en inglés, ya que esta página aún no ha sido traducida por nuestro equipo. ¿Te gustaría ayudar? Consulta la página 'Contribuir'

@chalin
Copy link
Contributor Author

chalin commented Feb 15, 2025

@iguitton - oh, now that I've read the messages that you provided, I see that there's been a misunderstanding. Fallback pages will have a single message that will not be changed (by the OTel.io site) whether the user decides to enable Google translate or not. So, if you wish to provide a translation, it should be a translation of the text given in https://github.com/open-telemetry/opentelemetry.io/pull/6287/files.

@danielmasegosa
Copy link
Contributor

Hey @chalin,

Do you have any updates on how we want to set up the locale-specific banner messages?
I'd be happy to add the es translation for the banner.

@chalin
Copy link
Contributor Author

chalin commented Apr 24, 2025

@danielmasegosa
Copy link
Contributor

I'd be happy to do it! @chalin

I also started translating the contributing page into Spanish.
Is there any issue tracking this kind of translation work, or should I just go ahead and create a PR?

@chalin
Copy link
Contributor Author

chalin commented Apr 25, 2025

@danielmasegosa - coordinate with @open-telemetry/docs-es-approvers (such as @krol3 and @theletterf) for the process used by the es locale. Cheers!

@danielmasegosa
Copy link
Contributor

I've created the PR for this here

@danielmasegosa
Copy link
Contributor

danielmasegosa commented Apr 29, 2025

Hi @chalin, the PR for the Spanish banner is now merged.
We can mark the es check in this issue as done! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request i18n Internationalization and localization
Projects
Status: No status
Development

No branches or pull requests

4 participants