Skip to content

Commit 07d1da9

Browse files
authored
Mark .instrumentation as experimental (#1620)
1 parent 78bd695 commit 07d1da9

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/Config/SDK/ComponentProvider/InstrumentationConfigurationRegistry.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ class InstrumentationConfigurationRegistry implements ComponentProvider
2323
{
2424
/**
2525
* @param array{
26-
* instrumentation: array{
26+
* "instrumentation/development": array{
2727
* php: list<ComponentPlugin<InstrumentationConfiguration>>,
2828
* general: list<ComponentPlugin<GeneralInstrumentationConfiguration>>
2929
* }
@@ -33,11 +33,11 @@ public function createPlugin(array $properties, Context $context): Configuration
3333
{
3434
$configurationRegistry = new ConfigurationRegistry();
3535
/** @phpstan-ignore-next-line */
36-
foreach ($properties['instrumentation']['php'] ?? [] as $configuration) {
36+
foreach ($properties['instrumentation/development']['php'] ?? [] as $configuration) {
3737
$configurationRegistry->add($configuration->create($context));
3838
}
3939
/** @phpstan-ignore-next-line */
40-
foreach ($properties['instrumentation']['general'] ?? [] as $configuration) {
40+
foreach ($properties['instrumentation/development']['general'] ?? [] as $configuration) {
4141
$configurationRegistry->add($configuration->create($context));
4242
}
4343

@@ -50,7 +50,7 @@ public function getConfig(ComponentProviderRegistry $registry, NodeBuilder $buil
5050
$root
5151
->ignoreExtraKeys()
5252
->children()
53-
->arrayNode('instrumentation')
53+
->arrayNode('instrumentation/development')
5454
->ignoreExtraKeys()
5555
->append($registry->componentMap('php', InstrumentationConfiguration::class))
5656
->append($registry->componentMap('general', GeneralInstrumentationConfiguration::class))

tests/Unit/SDK/fixtures/otel-sdk.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ tracer_provider:
1111
propagator:
1212
composite: []
1313

14-
instrumentation:
14+
instrumentation/development:
1515
php:
1616
example_instrumentation:
1717
span_name: my-span

0 commit comments

Comments
 (0)