test: test Node.js 24 in CI (#5661)

Co-authored-by: Chengzhong Wu <[email protected]>

Author: cjihrig

.github/workflows/unit-test.yml

@@ -18,6 +18,7 @@ jobs:
           - "20"
           - "22"
           - "23"
+          - "24"
     runs-on: ubuntu-latest
     env:
       NPM_CONFIG_UNSAFE_PERM: true
@@ -45,7 +46,8 @@ jobs:
         if: ${{
           matrix.node_version == '20' ||
           matrix.node_version == '22' ||
-          matrix.node_version == '23'
+          matrix.node_version == '23' ||
+          matrix.node_version == '24'
           }}
 
       - name: Bootstrap
@@ -55,13 +57,13 @@ jobs:
         run: npm run compile
 
       - run: npm test
-        if: ${{ matrix.node_version != '23' }}
-      # Node.js 23 type stripping conflicts with mocha usage of ts-node.
+        if: ${{ matrix.node_version != '23' && matrix.node_version != '24' }}
+      # Node.js >= 23 type stripping conflicts with mocha usage of ts-node.
       # See https://github.com/open-telemetry/opentelemetry-js/issues/5415
       - run: npm test
         env:
           NODE_OPTIONS: '--no-experimental-strip-types'
-        if: ${{ matrix.node_version == '23' }}
+        if: ${{ matrix.node_version == '23' || matrix.node_version == '24' }}
 
       - name: Report Coverage
         uses: codecov/codecov-action@v5

experimental/CHANGELOG.md

@@ -35,6 +35,7 @@ For notes on migrating to 2.x / 0.200.x see [the upgrade guide](doc/upgrade-to-2
 * refactor(sdk-node): update semconv usage to `ATTR_` exports [#5668](https://github.com/open-telemetry/opentelemetry-js/pull/5668) @trentm
 * chore(sdk-node): Refactored using `get*FromEnv` utility function instead of `process.env` for NodeSDK's resource detector setup. [#5582](https://github.com/open-telemetry/opentelemetry-js/pull/5582) @beeme1mr
 * chore(sdk-node): Refactored using `get*FromEnv` utility function instead of `process.env` for NodeSDK's logging setup. [#5563](https://github.com/open-telemetry/opentelemetry-js/issues/5563) @weyert
+* test: test Node.js 24 in CI [#5661](https://github.com/open-telemetry/opentelemetry-js/pull/5661) @cjihrig
 
 ## 0.200.0
 

experimental/packages/opentelemetry-instrumentation-http/test/functionals/http-package.test.ts

@@ -109,10 +109,10 @@ describe('Packages', () => {
         switch (name) {
           case 'axios':
             assert.ok(
-              result.request._headers[DummyPropagation.TRACE_CONTEXT_KEY]
+              result.request.getHeader(DummyPropagation.TRACE_CONTEXT_KEY)
             );
             assert.ok(
-              result.request._headers[DummyPropagation.SPAN_CONTEXT_KEY]
+              result.request.getHeader(DummyPropagation.SPAN_CONTEXT_KEY)
             );
             break;
           case 'superagent':

experimental/packages/opentelemetry-instrumentation-http/test/functionals/https-package.test.ts

@@ -109,10 +109,10 @@ describe('Packages', () => {
         switch (name) {
           case 'axios':
             assert.ok(
-              result.request._headers[DummyPropagation.TRACE_CONTEXT_KEY]
+              result.request.getHeader(DummyPropagation.TRACE_CONTEXT_KEY)
             );
             assert.ok(
-              result.request._headers[DummyPropagation.SPAN_CONTEXT_KEY]
+              result.request.getHeader(DummyPropagation.SPAN_CONTEXT_KEY)
             );
             break;
           case 'superagent':