Skip to content

Jaeger propagator is missing the .fields() method, is incompatible with latest TextMapPropagator #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 of 2 tasks
jtmalinowski opened this issue Nov 24, 2020 · 1 comment
Closed
1 of 2 tasks

Jaeger propagator is missing the .fields() method, is incompatible with latest TextMapPropagator #267

jtmalinowski opened this issue Nov 24, 2020 · 1 comment
Labels
discussion

Comments

@jtmalinowski
Copy link
Contributor

jtmalinowski commented Nov 24, 2020 •
edited
Loading

As part of open-telemetry/opentelemetry-js#1680 I need to import JaegerHttpTracePropagator into @opentelemetry/node, but then compilation fails, because .fields() is not implemented.

  • This only affects the JavaScript OpenTelemetry library
  • This may affect other libraries, but I would like to get opinions here first

Also: @opentelemetry/propagator-jaeger will now become a dependency of @opentelemetry/node, so a release is needed.
@jtmalinowski jtmalinowski mentioned this issue Nov 24, 2020
Merged
@Flarna
Copy link
Member

Flarna commented Jan 22, 2021

fixed via #268

@Flarna Flarna closed this as completed Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jtmalinowski @Flarna