Skip to content

Commit 6844e16

Browse files
feat(opentelemetry-instrumentation-pg): update types/pg version (#2823)
Co-authored-by: Marc Pichler <[email protected]>
1 parent 24d8eab commit 6844e16

File tree

4 files changed

+156
-18
lines changed

4 files changed

+156
-18
lines changed

package-lock.json

Lines changed: 147 additions & 17 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

plugins/node/opentelemetry-instrumentation-pg/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@
7373
"@opentelemetry/instrumentation": "^0.201.0",
7474
"@opentelemetry/semantic-conventions": "^1.27.0",
7575
"@opentelemetry/sql-common": "^0.41.0",
76-
"@types/pg": "8.6.1",
76+
"@types/pg": "8.15.1",
7777
"@types/pg-pool": "2.0.6"
7878
},
7979
"homepage": "https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/plugins/node/opentelemetry-instrumentation-pg#readme"

plugins/node/opentelemetry-instrumentation-pg/src/internal-types.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,10 @@ export interface PgPoolOptionsParams {
5454
idleTimeoutMillis: number; // the minimum amount of time that an object may sit idle in the pool before it is eligible for eviction due to idle time
5555
maxClient: number; // maximum size of the pool
5656
connectionString?: string; // connection string if provided directly
57+
max: number;
58+
maxUses: number;
59+
allowExitOnIdle: boolean;
60+
maxLifetimeSeconds: number;
5761
}
5862

5963
export const EVENT_LISTENERS_SET = Symbol(

plugins/node/opentelemetry-instrumentation-pg/test/utils.test.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -246,6 +246,10 @@ describe('utils.ts', () => {
246246
database: 'database_name',
247247
idleTimeoutMillis: 10,
248248
maxClient: 5,
249+
max: 5,
250+
maxUses: 5,
251+
allowExitOnIdle: true,
252+
maxLifetimeSeconds: 10,
249253
};
250254

251255
assert.strictEqual(

0 commit comments

Comments
 (0)