Skip to content

Stabilize otel.experimental.resource.disabled.keys #6777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jack-berg opened this issue Oct 10, 2024 · 4 comments · Fixed by #6809
Closed

Stabilize otel.experimental.resource.disabled.keys #6777

jack-berg opened this issue Oct 10, 2024 · 4 comments · Fixed by #6809
Assignees
Labels
Feature Request Suggest an idea for this project

Comments

@jack-berg
Copy link
Member

As discussed in this comment, otel.experimental.resource.disabled.keys has been experimental for a while - introduced in #4169 on 2/17/2022.

It seems both important and correctly modeled. We should stabilize it.

@jack-berg jack-berg added the Feature Request Suggest an idea for this project label Oct 10, 2024
@trask
Copy link
Member

trask commented Oct 10, 2024

just want to confirm that we are ok with expanding the surface area of stable env var / system properties given that they won't be compatible with the upcoming configuration v2 (declarative configuration)?

https://github.com/open-telemetry/opentelemetry-configuration/blob/844869c2eb37a07ff6471923b3c0488078840bd5/examples/kitchen-sink.yaml#L368

@jack-berg
Copy link
Member Author

These properties are around to stay, even if there's an alternative recommended approach. I'm reluctant to expand the surface area, but don't consider promotion to stable an expansion.

@vasantteja
Copy link
Contributor

Can I work on this?

@jack-berg jack-berg assigned jack-berg and vasantteja and unassigned jack-berg Oct 16, 2024
@jack-berg
Copy link
Member Author

Sure - I've assigned you.

Quick note: we'll want to retain support for otel.experimental.resource.disabled.keys for at least 1 minor release cycle, but warn if we see it. Pseudocode is something like:

List<String> disabledKeys = configProperties.getList("otel.resource.disabled.keys");
if (disabledKeys.isEmpty()) {
  disabledKeys = configProperties.getList("otel.experimental.resource.disabled.keys");
  if (!disabledKeys.isEmpty()) {
     // log warning
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Suggest an idea for this project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants