Skip to content

Commit 441ca55

Browse files
committed
make component loader internal to give it time to incubate
1 parent 74e8add commit 441ca55

File tree

6 files changed

+10
-14
lines changed

6 files changed

+10
-14
lines changed
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,5 @@
11
Comparing source compatibility of against
22
*** MODIFIED CLASS: PUBLIC FINAL io.opentelemetry.sdk.autoconfigure.AutoConfiguredOpenTelemetrySdkBuilder (not serializable)
33
=== CLASS FILE FORMAT VERSION: 52.0 <- 52.0
4-
+++ NEW METHOD: PUBLIC(+) io.opentelemetry.sdk.autoconfigure.AutoConfiguredOpenTelemetrySdkBuilder setComponentLoader(io.opentelemetry.sdk.autoconfigure.ComponentLoader)
4+
+++ NEW METHOD: PUBLIC(+) io.opentelemetry.sdk.autoconfigure.AutoConfiguredOpenTelemetrySdkBuilder setComponentLoader(io.opentelemetry.sdk.autoconfigure.internal.ComponentLoader)
55
*** MODIFIED METHOD: PUBLIC (<- PACKAGE_PROTECTED) io.opentelemetry.sdk.autoconfigure.AutoConfiguredOpenTelemetrySdkBuilder setConfig(io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties)
6-
+++ NEW INTERFACE: PUBLIC(+) ABSTRACT(+) io.opentelemetry.sdk.autoconfigure.ComponentLoader (not serializable)
7-
+++ CLASS FILE FORMAT VERSION: 52.0 <- n.a.
8-
+++ NEW SUPERCLASS: java.lang.Object
9-
+++ NEW METHOD: PUBLIC(+) ABSTRACT(+) java.lang.Iterable<T> load(java.lang.Class<T>)
10-
GENERIC TEMPLATES: +++ T:java.lang.Object
11-
+++ NEW METHOD: PUBLIC(+) java.util.Map<java.lang.String,T> loadConfigurableProviders(java.lang.Class<T>)
12-
GENERIC TEMPLATES: +++ T:io.opentelemetry.sdk.autoconfigure.spi.ConfigurableProvider
13-
+++ NEW METHOD: PUBLIC(+) java.util.List<T> loadOrdered(java.lang.Class<T>)
14-
GENERIC TEMPLATES: +++ T:io.opentelemetry.sdk.autoconfigure.spi.Ordered

sdk-extensions/autoconfigure/src/main/java/io/opentelemetry/sdk/autoconfigure/AutoConfiguredOpenTelemetrySdkBuilder.java

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
import io.opentelemetry.context.propagation.TextMapPropagator;
1414
import io.opentelemetry.sdk.OpenTelemetrySdk;
1515
import io.opentelemetry.sdk.OpenTelemetrySdkBuilder;
16+
import io.opentelemetry.sdk.autoconfigure.internal.ComponentLoader;
1617
import io.opentelemetry.sdk.autoconfigure.internal.SpiHelper;
1718
import io.opentelemetry.sdk.autoconfigure.spi.AutoConfigurationCustomizer;
1819
import io.opentelemetry.sdk.autoconfigure.spi.AutoConfigurationCustomizerProvider;

sdk-extensions/autoconfigure/src/main/java/io/opentelemetry/sdk/autoconfigure/ComponentLoader.java renamed to sdk-extensions/autoconfigure/src/main/java/io/opentelemetry/sdk/autoconfigure/internal/ComponentLoader.java

+7-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* SPDX-License-Identifier: Apache-2.0
44
*/
55

6-
package io.opentelemetry.sdk.autoconfigure;
6+
package io.opentelemetry.sdk.autoconfigure.internal;
77

88
import io.opentelemetry.sdk.autoconfigure.spi.ConfigurableProvider;
99
import io.opentelemetry.sdk.autoconfigure.spi.Ordered;
@@ -14,7 +14,12 @@
1414
import java.util.stream.Collectors;
1515
import java.util.stream.StreamSupport;
1616

17-
/** A loader for components that are discovered via SPI. */
17+
/**
18+
* A loader for components that are discovered via SPI.
19+
*
20+
* <p>This class is internal and is hence not for public use. Its APIs are unstable and can change
21+
* at any time.
22+
*/
1823
public interface ComponentLoader {
1924
<T> Iterable<T> load(Class<T> spiClass);
2025

sdk-extensions/autoconfigure/src/main/java/io/opentelemetry/sdk/autoconfigure/internal/SpiHelper.java

-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
package io.opentelemetry.sdk.autoconfigure.internal;
77

8-
import io.opentelemetry.sdk.autoconfigure.ComponentLoader;
98
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
109
import io.opentelemetry.sdk.autoconfigure.spi.ConfigurableProvider;
1110
import io.opentelemetry.sdk.autoconfigure.spi.Ordered;

sdk-extensions/autoconfigure/src/test/java/io/opentelemetry/sdk/autoconfigure/AutoConfiguredOpenTelemetrySdkTest.java

+1
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
import io.opentelemetry.context.propagation.TextMapPropagator;
3737
import io.opentelemetry.internal.testing.slf4j.SuppressLogger;
3838
import io.opentelemetry.sdk.OpenTelemetrySdk;
39+
import io.opentelemetry.sdk.autoconfigure.internal.ComponentLoader;
3940
import io.opentelemetry.sdk.autoconfigure.internal.SpiHelper;
4041
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
4142
import io.opentelemetry.sdk.autoconfigure.spi.ConfigurationException;

sdk-extensions/autoconfigure/src/test/java/io/opentelemetry/sdk/autoconfigure/internal/SpiHelperTest.java

-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
import static org.mockito.Mockito.verify;
1616
import static org.mockito.Mockito.when;
1717

18-
import io.opentelemetry.sdk.autoconfigure.ComponentLoader;
1918
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
2019
import io.opentelemetry.sdk.autoconfigure.spi.ConfigurableProvider;
2120
import io.opentelemetry.sdk.autoconfigure.spi.ResourceProvider;

0 commit comments

Comments
 (0)