-
Notifications
You must be signed in to change notification settings - Fork 945
gRPC trace missing #2564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@anuraaga Any idea which release this might go into? Seems like a major problem to me if trace disappears in a mundane client interceptor. |
Hoping it gets in soon - I started with a prerequisite for it but have some tricky issues |
@anuraaga please provide us an update on this. |
Hi @ankitgaur-cer @asarkar - sorry for not getting to this until now. Actually 1.1.0 includes the context bridge, and I can run the repro and the test passes! @asarkar please confirm that the issue has been solved. |
@anuraaga Using io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom-alpha:1.1.0-alpha, I see the trace, but also a lot of the following error:
|
Hi @asarkar - looks like it was a bug in kotlin coroutines up to 1.4.2. I updated your code to 1.4.3 and the error goes away. https://github.com/Kotlin/kotlinx.coroutines/releases/tag/1.4.3
|
Seems to be working. I'll leave this ticket open until we get a chance to verify more thoroughly. Thank you. |
@asarkar Any news on "verify more thoroughly"? :) Can we close this ticket now? |
@iNikem Sorry, the detail QA verification is supposed to happen next week. I understand our scheduling is not your problem, so if you must, go ahead and close it, and if something horrible comes up, I'll reopen it. However, it'd be nice if you could wait one more week. Up to you. |
I see this with 1.1.0 in GCP and app can't start:
|
@denis111 That is a log message, are you also seeing an exception causing the app to fail to start? |
@anuraaga I seem to be having the same problem as @denis111 using kotlin, spring boot and the Google cloud trace exporter (0.0.15-alpha). I'm using kotlin coroutines version 1.4.3, so that shouldn't be an issue. |
Hi @skoppers is your app also failing to startup? If so, do you have an exception where it actually fails? That would be helpful to know. Also does it only happen on GCP, not localhost presumably since it triggers that code path? |
Yes it happens at startup, there are actually 2 exception: 1 from the javaagent and 1 from the spring application: spring application:
javaagent:
I'm currently running into some issues trying to run it locally. However, I think this error will also occur then, as you need to setup credentials for the google cloud exporter to work properly. |
Thanks for the stack traces. I've currently not been able to repro locally but if you are able to come up with one that will be really great! In the meantime, I have tried an approach to make the bridge more robust in The next nightly snapshot will have it so if you are able to give it a try that would be very helpful. |
Ah, seems like last nights build failed. In the meantime, I'll see if I can reproduce it in a new project. |
@skoppers A new snapshot build was published, can you give it a try? https://oss.sonatype.org/content/repositories/snapshots/io/opentelemetry/javaagent/opentelemetry-javaagent/1.2.0-SNAPSHOT/ |
@anuraaga Just tried the new snapshot. The application doesn't crash anymore and seems to export some traces. However, the java agent still throw a lot of errors. This is thrown a couple of times before startup:
After startup, it seems that the same error triggers every time the google cloud storage library is used, but I need to look into this further.
|
Thanks for verifying @skoppers! That log message is incorrect, I've sent https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/2970/files to remove it, there should otherwise not be any harm to your app which sounds correct based on your verification. |
@asarkar It's been a while since adding the fix for the original part of this issue, let's go ahead and close this as it's gotten a bit off topic (no problem, but actually these were two different issues). If anything comes up feel free to reopen this or open another issue. @skoppers If you come up with any updates, possibly after a snapshot with that PR is released, do you mind sharing on #2959? Let's use that issue for what you're seeing. |
@anuraaga Yes will do! Thanks so much for the help! |
@anuraaga With Kotlin 1.4.32 and Coroutines 1.4.3, I don't see the exception anymore. Thanks for your help. |
Spin off from #1550. gRPC client interceptor missing trace. Quoting @anuraaga's comment:
Attached app can be used to reproduce the issue. Extract and run
./gradlew test
from the root directory.otel-grpc-tracing.zip
The text was updated successfully, but these errors were encountered: