You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I would also expect that the url.template attribute is populated with /api/example/{id} (This attribute is in development so I'm not sure on this projects policy on this)
The current span names makes trawling though traces difficult
Describe the solution you'd like
Instrumentation names the spans and populates url.template when the resources plugin is used.
Describe alternatives you've considered
Accept the span names are what they are.
Additional context
I would be happy to take a stab at implementing this. I would need some guidance on where to start however (or if this is possible)
I think the solution to would be to add String getUrlTemplate(REQUEST request) to HttpCommonAttributesGetter and have the ktor client implement it. To avoid massive changes I would default getUrlTemplate to null. Finally I would have to modify HttpSpanNameExtractor to use getUrlTemplate to name the span. I would also want to set url.template in HttpCommonAttributesExtractor (again using getUrlTemplate)
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
When using a Ktor client with https://ktor.io/docs/client-resources.html
I would expect the span name to be
GET /api/example/{id}
per https://github.com/open-telemetry/semantic-conventions/blob/main/docs/http/http-spans.md#nameI would also expect that the
url.template
attribute is populated with/api/example/{id}
(This attribute is in development so I'm not sure on this projects policy on this)The current span names makes trawling though traces difficult
Describe the solution you'd like
Instrumentation names the spans and populates
url.template
when the resources plugin is used.Describe alternatives you've considered
Additional context
I would be happy to take a stab at implementing this.
I would need some guidance on where to start however (or if this is possible)I think the solution to would be to add
String getUrlTemplate(REQUEST request)
toHttpCommonAttributesGetter
and have the ktor client implement it. To avoid massive changes I would defaultgetUrlTemplate
to null. Finally I would have to modifyHttpSpanNameExtractor
to usegetUrlTemplate
to name the span. I would also want to seturl.template
inHttpCommonAttributesExtractor
(again usinggetUrlTemplate
)The text was updated successfully, but these errors were encountered: