Skip to content

Commit d2b7fed

Browse files
committed
addressed comments
1 parent 09e823a commit d2b7fed

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

instrumentation/aws-sdk/aws-sdk-1.11/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v1_11/DynamoDbAttributesExtractor.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
public class DynamoDbAttributesExtractor implements AttributesExtractor<Request<?>, Response<?>> {
2020

2121
private static final AttributeKey<String> DB_SYSTEM = AttributeKey.stringKey("db.system");
22-
private static final AttributeKey<List<String>> AWS_TABLE_NAMES =
22+
private static final AttributeKey<List<String>> AWS_DYNAMODB_TABLE_NAMES =
2323
AttributeKey.stringArrayKey("aws.dynamodb.table_names");
2424

2525
private static final String DYNAMODB = "dynamodb";
@@ -29,7 +29,7 @@ public void onStart(AttributesBuilder attributes, Context parentContext, Request
2929
AttributesExtractorUtil.internalSet(attributes, DB_SYSTEM, DYNAMODB);
3030
String tableName = RequestAccess.getTableName(request.getOriginalRequest());
3131
AttributesExtractorUtil.internalSet(
32-
attributes, AWS_TABLE_NAMES, Collections.singletonList(tableName));
32+
attributes, AWS_DYNAMODB_TABLE_NAMES, Collections.singletonList(tableName));
3333
}
3434

3535
@Override

instrumentation/aws-sdk/aws-sdk-1.11/testing/src/main/java/io/opentelemetry/instrumentation/awssdk/v1_11/AbstractSnsClientTest.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
package io.opentelemetry.instrumentation.awssdk.v1_11;
77

8-
import static io.opentelemetry.api.common.AttributeKey.stringKey;
98
import static io.opentelemetry.sdk.testing.assertj.OpenTelemetryAssertions.equalTo;
109
import static io.opentelemetry.semconv.incubating.MessagingIncubatingAttributes.MESSAGING_DESTINATION_NAME;
1110
import static java.util.Collections.singletonList;
@@ -56,7 +55,7 @@ public void testSendRequestWithMockedResponse(Function<AmazonSNS, Object> call)
5655
server.enqueue(HttpResponse.of(HttpStatus.OK, MediaType.PLAIN_TEXT_UTF_8, body));
5756

5857
List<AttributeAssertion> additionalAttributes =
59-
singletonList(equalTo(stringKey(MESSAGING_DESTINATION_NAME.toString()), "somearn"));
58+
singletonList(equalTo(MESSAGING_DESTINATION_NAME, "somearn"));
6059

6160
Object response = call.apply(client);
6261
assertRequestWithMockedResponse(

0 commit comments

Comments
 (0)