Skip to content

Commit cae6644

Browse files
authored
Merge pull request #2 from JonasKunz/indy-reflection-recursion
Fix bootstrap proxy injection
2 parents 6747406 + e7d4a1f commit cae6644

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/instrumentation/indy/IndyModuleRegistry.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -45,12 +45,6 @@ public static InstrumentationModuleClassLoader getInstrumentationClassLoader(
4545

4646
String groupName = getModuleGroup(module);
4747

48-
// this is a hack attempt to make it work
49-
if (instrumentedClassLoader != null && instrumentedClassLoader.getClass().getName()
50-
.startsWith("io.opentelemetry.javaagent.tooling.HelperInjector$1")) {
51-
instrumentedClassLoader = null;
52-
}
53-
5448
Map<String, InstrumentationModuleClassLoader> loadersByGroupName =
5549
instrumentationClassLoaders.get(instrumentedClassLoader);
5650

muzzle/src/main/java/io/opentelemetry/javaagent/tooling/HelperInjector.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,10 @@ public DynamicType.Builder<?> transform(
172172
injectedClassLoaders.computeIfAbsent(
173173
maskNullClassLoader(classLoader),
174174
cl -> {
175-
List<HelperClassDefinition> helpers = helperClassesGenerator.apply(cl);
175+
176+
List<HelperClassDefinition> helpers = helperClassesGenerator.apply(
177+
isBootClassLoader(cl) ? null : cl
178+
);
176179

177180
LinkedHashMap<String, Supplier<byte[]>> classesToInject =
178181
helpers.stream()

0 commit comments

Comments
 (0)