Skip to content

Commit 58c3a21

Browse files
committed
fix merge
1 parent 80e80a0 commit 58c3a21

File tree

1 file changed

+6
-9
lines changed

1 file changed

+6
-9
lines changed

smoke-tests-otel-starter/src/test/java/io/opentelemetry/smoketest/OtelSpringStarterSmokeTest.java

+6-9
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
import io.opentelemetry.sdk.trace.data.SpanData;
3535
import io.opentelemetry.sdk.trace.export.SpanExporter;
3636
import io.opentelemetry.semconv.HttpAttributes;
37+
import io.opentelemetry.semconv.UrlAttributes;
3738
import io.opentelemetry.semconv.incubating.CodeIncubatingAttributes;
3839
import io.opentelemetry.semconv.incubating.DbIncubatingAttributes;
3940
import io.opentelemetry.spring.smoketest.OtelSpringStarterSmokeTestApplication;
@@ -214,7 +215,7 @@ void propertyConversion() {
214215
}
215216

216217
@Test
217-
void shouldSendTelemetry() throws InterruptedException {
218+
void shouldSendTelemetry() {
218219
testRestTemplate.getForObject(OtelSpringStarterSmokeTestController.PING, String.class);
219220

220221
// Span
@@ -226,9 +227,7 @@ void shouldSendTelemetry() throws InterruptedException {
226227
clientSpan
227228
.hasKind(SpanKind.CLIENT)
228229
.hasAttributesSatisfying(
229-
a ->
230-
assertThat(a.get(HttpAttributes.URL_FULL))
231-
.endsWith("/ping")),
230+
a -> assertThat(a.get(UrlAttributes.URL_FULL)).endsWith("/ping")),
232231
serverSpan ->
233232
serverSpan
234233
.hasKind(SpanKind.SERVER)
@@ -255,7 +254,7 @@ void shouldSendTelemetry() throws InterruptedException {
255254
}
256255

257256
@Test
258-
void restTemplateClient() throws InterruptedException {
257+
void restTemplateClient() {
259258
testRestTemplate.getForObject(OtelSpringStarterSmokeTestController.REST_TEMPLATE, String.class);
260259

261260
TracesAssert.assertThat(expectSpans(4))
@@ -267,7 +266,7 @@ void restTemplateClient() throws InterruptedException {
267266
.hasKind(SpanKind.CLIENT)
268267
.hasAttributesSatisfying(
269268
a ->
270-
assertThat(a.get(SemanticAttributes.URL_FULL))
269+
assertThat(a.get(UrlAttributes.URL_FULL))
271270
.endsWith("/rest-template")),
272271
serverSpan ->
273272
serverSpan
@@ -277,9 +276,7 @@ void restTemplateClient() throws InterruptedException {
277276
nestedClientSpan
278277
.hasKind(SpanKind.CLIENT)
279278
.hasAttributesSatisfying(
280-
a ->
281-
assertThat(a.get(SemanticAttributes.URL_FULL))
282-
.endsWith("/ping")),
279+
a -> assertThat(a.get(UrlAttributes.URL_FULL)).endsWith("/ping")),
283280
nestedServerSpan ->
284281
nestedServerSpan
285282
.hasKind(SpanKind.SERVER)

0 commit comments

Comments
 (0)