Skip to content

Commit 29fca2f

Browse files
committed
fix test
1 parent f87356a commit 29fca2f

File tree

3 files changed

+11
-15
lines changed

3 files changed

+11
-15
lines changed

instrumentation/spring/spring-boot-autoconfigure/src/main/java/io/opentelemetry/instrumentation/spring/autoconfigure/instrumentation/r2dbc/R2dbcAutoConfiguration.java

+1-5
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,6 @@ public R2dbcAutoConfiguration() {}
3131
static R2dbcInstrumentingPostProcessor r2dbcInstrumentingPostProcessor(
3232
ObjectProvider<OpenTelemetry> openTelemetryProvider,
3333
ObjectProvider<ConfigProperties> configPropertiesProvider) {
34-
return new R2dbcInstrumentingPostProcessor(
35-
openTelemetryProvider,
36-
configPropertiesProvider
37-
.getObject()
38-
.getBoolean("otel.instrumentation.common.db-statement-sanitizer.enabled", true));
34+
return new R2dbcInstrumentingPostProcessor(openTelemetryProvider, configPropertiesProvider);
3935
}
4036
}

instrumentation/spring/spring-boot-autoconfigure/src/main/java/io/opentelemetry/instrumentation/spring/autoconfigure/instrumentation/r2dbc/R2dbcInstrumentingPostProcessor.java

+9-4
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
import io.opentelemetry.api.OpenTelemetry;
99
import io.opentelemetry.instrumentation.r2dbc.v1_0.R2dbcTelemetry;
10+
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
1011
import io.r2dbc.spi.ConnectionFactory;
1112
import io.r2dbc.spi.ConnectionFactoryOptions;
1213
import org.springframework.aop.scope.ScopedProxyUtils;
@@ -17,20 +18,24 @@
1718
class R2dbcInstrumentingPostProcessor implements BeanPostProcessor {
1819

1920
private final ObjectProvider<OpenTelemetry> openTelemetryProvider;
20-
private final boolean statementSanitizationEnabled;
21+
private final ObjectProvider<ConfigProperties> configPropertiesProvider;
2122

2223
R2dbcInstrumentingPostProcessor(
23-
ObjectProvider<OpenTelemetry> openTelemetryProvider, boolean statementSanitizationEnabled) {
24+
ObjectProvider<OpenTelemetry> openTelemetryProvider,
25+
ObjectProvider<ConfigProperties> configPropertiesProvider) {
2426
this.openTelemetryProvider = openTelemetryProvider;
25-
this.statementSanitizationEnabled = statementSanitizationEnabled;
27+
this.configPropertiesProvider = configPropertiesProvider;
2628
}
2729

2830
@Override
2931
public Object postProcessAfterInitialization(Object bean, String beanName) {
3032
if (bean instanceof ConnectionFactory && !ScopedProxyUtils.isScopedTarget(beanName)) {
3133
ConnectionFactory connectionFactory = (ConnectionFactory) bean;
3234
return R2dbcTelemetry.builder(openTelemetryProvider.getObject())
33-
.setStatementSanitizationEnabled(statementSanitizationEnabled)
35+
.setStatementSanitizationEnabled(
36+
configPropertiesProvider
37+
.getObject()
38+
.getBoolean("otel.instrumentation.common.db-statement-sanitizer.enabled", true))
3439
.build()
3540
.wrapConnectionFactory(connectionFactory, getConnectionFactoryOptions(connectionFactory));
3641
}

smoke-tests-otel-starter/spring-boot-reactive-common/src/main/java/io/opentelemetry/spring/smoketest/AbstractOtelReactiveSpringStarterSmokeTest.java

+1-6
Original file line numberDiff line numberDiff line change
@@ -68,18 +68,13 @@ void webClientAndWebFluxAndR2dbc() {
6868
assertThat(s.getName())
6969
.isEqualToIgnoringCase("SELECT testdb.PLAYER"))
7070
.hasAttribute(DbIncubatingAttributes.DB_NAME, "testdb")
71-
.hasAttributesSatisfying(
72-
a ->
73-
assertThat(a.get(DbIncubatingAttributes.DB_SQL_TABLE))
74-
.isEqualToIgnoringCase("PLAYER"))
75-
.hasAttribute(DbIncubatingAttributes.DB_OPERATION, "SELECT")
7671
// 1 is not replaced by ?,
7772
// otel.instrumentation.common.db-statement-sanitizer.enabled=false
7873
.hasAttributesSatisfying(
7974
a ->
8075
assertThat(a.get(DbIncubatingAttributes.DB_STATEMENT))
8176
.isEqualToIgnoringCase(
82-
"SELECT PLAYER.* FROM PLAYER WHERE PLAYER.ID = 1 LIMIT ?"))
77+
"SELECT PLAYER.* FROM PLAYER WHERE PLAYER.ID = $1 LIMIT 2"))
8378
.hasAttribute(DbIncubatingAttributes.DB_SYSTEM, "h2")));
8479
}
8580
}

0 commit comments

Comments
 (0)