prometheus: remove otel_scope_info #6770
Conversation
pellared
requested review from
MrAlias,
XSAM,
dashpole and
dmathieu
as code owners
pellared
added
blocked:specification
|
|
||
| // Invalid label or metric name leads to error returned from | ||
| // createScopeInfoMetric. | ||
| invalidName := string([]byte{0xff, 0xfe, 0xfd}) |
There was a problem hiding this comment.
This is an invalid UTF and I do not think this test makes sense.
We would have also problems when attributes keys or values would be invalid UTF.
|
@dashpole, I think it is safe to merge. Removing We had an offline conversation with @ArthurSens and @jsuereth, the conclusion was that a migration flag is important for collector components. For Go SDK, if users want to rely on legacy |
pellared
changed the title
pellared
removed
the
blocked:specification
|
SIG meeting: |
…ls (#5947) Fixes #5846 Towards open-telemetry/opentelemetry-specification#4223 (first two points from open-telemetry/opentelemetry-specification#4223 (comment)) - Add instrumentation scope schema URL as `otel_scope_schema_url` label to exported metrics - Add instrumentation scope attributes as `otel_scope_[attribute]` labels to exported metrics Side notes: - The exporter does not seem to work correctly if the end user adds e.g. an `otel_scope_name` attribute. I think the exporter should ignore all attributes with names that have prefix `otel_scope_`. This scenario is also not covered by the spec. I think it may be covered by a separate PR and issue. - Removal of `otel_scope_info` metric would be handled as a separate PR. #6770
Fixes #6768
Towards open-telemetry/opentelemetry-specification#4223 (last point from from open-telemetry/opentelemetry-specification#4223 (comment))
otel_scope_infometric