[prometheusexporter] disable exposition of unescaped UTF-8 names #6723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change prevents unexpected behavior when clients scrape requesting UTF-8.
Previously the SDK would return escaped metric names, but label names would be in UTF-8 format.
A configuration option will be added to allow the user to choose to send unescaped ("untranslated") UTF-8 names.
Fixes open-telemetry#6722
ywwg
requested review from
MrAlias,
XSAM,
dashpole,
pellared and
dmathieu
as code owners
|
This will be breaking for users that have moved to the new names. Can we instead fix issues with escaping? We can discuss adding the translation option in #6668 |
|
yes this seems to be the consensus of people. closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prevents unexpected behavior when clients scrape requesting UTF-8. Previously the SDK would return escaped metric names, but label names would be in UTF-8 format.
In the future, a configuration option will be added to allow the user to choose to send unescaped ("untranslated") UTF-8 names.
Fixes #6722