Skip to content

add WithShutdownWait option to PeriodicReader #6678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

nktks
Copy link

@nktks nktks commented Apr 20, 2025

This PR is trying to fix #6677

  • added WithShutdownWait option to wait some duration to avoid export backend rate limit.

Copy link

linux-foundation-easycla bot commented Apr 20, 2025

CLA Signed


The committers listed above are authorized under a signed CLA.

Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks to be modifying the SDK to support an edge case that could be handled elsewhere. We should not grow the options like this.

I would recommend writing your own exporter or reader if you want this level of control.

@nktks
Copy link
Author

nktks commented Apr 21, 2025

Thanks for your review.
Let me close this PR.

@nktks nktks closed this Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metric PeriodicReader ignores interval at Shutdown
2 participants